fix: loopingselector fast scrolling skia #22218

ajpinedam · 2025-12-27T23:33:03Z

GitHub Issue: closes #21958

PR Type:

🐞 Bugfix

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

📝 Commits must be following the Conventional Commits specification.
🧪 Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
📚 Docs have been added/updated which fit documentation template (for bug fixes / features)
🖼️ Validated PR Screenshots Compare Test Run results.
❗ Contains NO breaking changes

Other information ℹ️

Copilot

Pull request overview

This PR addresses two related issues in Uno Platform's time picker controls: a fast scrolling problem in LoopingSelector (issue #21958) and a display issue in 12-hour clock mode where hour "0" should show as "12" (issue #22207).

Key changes:

Modified LoopingSelector to handle intermediate scroll events immediately by calling Balance(), preventing items from disappearing during fast scrolling
Fixed TimePicker hour generation to display "12" instead of "0" in 12-hour clock mode by checking the calendar's numeric hour value
Added test coverage for the 12-hour clock display fix

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

File	Description
src/Uno.UI/UI/Xaml/Controls/Primitives/LoopingSelector/LoopingSelector_Partial.cs	Implemented differentiated handling of intermediate vs final scroll events to fix fast scrolling item disappearance
src/Uno.UI/UI/Xaml/Controls/TimePicker/TimePickerFlyoutPresenter.partial.mux.cs	Added logic to override hour formatting for 12-hour clock when calendar hour is 0, ensuring "12" is displayed
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TimePicker.cs	Added test to verify 12-hour clock displays "12" as the first hour instead of "0"

src/Uno.UI/UI/Xaml/Controls/Primitives/LoopingSelector/LoopingSelector_Partial.cs

unodevops · 2025-12-27T23:58:27Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22218/wasm-skia-net9/index.html

unodevops · 2025-12-28T00:11:10Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22218/docs/index.html

unodevops · 2025-12-28T00:40:26Z

⚠️⚠️ The build 189560 has failed on Uno.UI - CI.

unodevops · 2025-12-28T19:48:41Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22218/wasm-skia-net9/index.html

unodevops · 2025-12-28T19:56:58Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22218/docs/index.html

unodevops · 2025-12-28T20:25:26Z

⚠️⚠️ The build 189576 has failed on Uno.UI - CI.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TimePicker.cs

unodevops · 2025-12-30T04:57:00Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22218/wasm-skia-net9/index.html

unodevops · 2025-12-30T05:04:18Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22218/docs/index.html

unodevops · 2025-12-30T06:18:48Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22218/wasm-skia-net9/index.html

unodevops · 2025-12-30T06:27:43Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22218/docs/index.html

unodevops · 2025-12-30T06:30:27Z

⚠️⚠️ The build 189662 has failed on Uno.UI - CI.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

src/Uno.UI/UI/Xaml/Controls/Primitives/LoopingSelector/LoopingSelector_Partial.cs

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TimePicker.cs

src/Uno.UI/UI/Xaml/Controls/Primitives/LoopingSelector/LoopingSelector_Partial.cs

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TimePicker.cs

unodevops · 2026-01-06T21:22:45Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22218/wasm-skia-net9/index.html

unodevops · 2026-01-06T21:23:14Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22218/docs/index.html

unodevops · 2026-01-07T16:35:57Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22218/wasm-skia-net9/index.html

unodevops · 2026-01-07T16:58:55Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22218/docs/index.html

unodevops · 2026-01-07T21:39:16Z

⚠️⚠️ The build 190287 has failed on Uno.UI - CI.

ajpinedam · 2026-01-08T16:19:31Z

/unobot backport release/stable/6.4

Copilot AI review requested due to automatic review settings December 27, 2025 23:33

Copilot started reviewing on behalf of ajpinedam December 27, 2025 23:33 View session

ajpinedam force-pushed the dev/anpi/fix.loopingselector.fast.scrolling.skia branch from 3094e1b to 63a3340 Compare December 27, 2025 23:33

Copilot AI reviewed Dec 27, 2025

View reviewed changes

src/Uno.UI/UI/Xaml/Controls/Primitives/LoopingSelector/LoopingSelector_Partial.cs Show resolved Hide resolved

Copilot AI review requested due to automatic review settings December 30, 2025 04:38

Copilot started reviewing on behalf of ajpinedam December 30, 2025 04:38 View session

ajpinedam marked this pull request as ready for review December 30, 2025 04:39

Copilot AI reviewed Dec 30, 2025

View reviewed changes

src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TimePicker.cs Outdated Show resolved Hide resolved

spouliot approved these changes Jan 6, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 6, 2026 20:59

ajpinedam force-pushed the dev/anpi/fix.loopingselector.fast.scrolling.skia branch from 5b4f68a to bbb5d5b Compare January 6, 2026 20:59

Copilot started reviewing on behalf of ajpinedam January 6, 2026 20:59 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

ajpinedam added 4 commits January 7, 2026 11:16

fix(TimePicker): numbers disappear while fast scrolling

8ad002b

test: TimePicker assert fast scrolling

9a864e5

chore: update tests

2327e2c

chore: fix ci

23b17dc

chore: update tests assertions

8ae3ea1

ajpinedam force-pushed the dev/anpi/fix.loopingselector.fast.scrolling.skia branch from bbb5d5b to 8ae3ea1 Compare January 7, 2026 16:16

jeromelaban merged commit 79cb5f6 into unoplatform:master Jan 8, 2026
51 of 53 checks passed

unodevops mentioned this pull request Jan 8, 2026

fix: loopingselector fast scrolling skia (backport #22218) #22314

Open

5 tasks

fix: loopingselector fast scrolling skia #22218

fix: loopingselector fast scrolling skia #22218

Conversation

ajpinedam commented Dec 27, 2025

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Other information ℹ️

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

unodevops commented Dec 27, 2025

Uh oh!

unodevops commented Dec 28, 2025

Uh oh!

unodevops commented Dec 28, 2025

Uh oh!

unodevops commented Dec 28, 2025

Uh oh!

unodevops commented Dec 28, 2025

Uh oh!

unodevops commented Dec 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

unodevops commented Dec 30, 2025

Uh oh!

unodevops commented Dec 30, 2025

Uh oh!

unodevops commented Dec 30, 2025

Uh oh!

unodevops commented Dec 30, 2025

Uh oh!

unodevops commented Dec 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unodevops commented Jan 6, 2026

Uh oh!

unodevops commented Jan 6, 2026

Uh oh!

unodevops commented Jan 7, 2026

Uh oh!

unodevops commented Jan 7, 2026

Uh oh!

unodevops commented Jan 7, 2026

Uh oh!

Uh oh!

ajpinedam commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants