ci(pypi): skip PyPy wheels so the v1.1.0 release can publish#80
Merged
Conversation
The v1.1.0 release run failed because cibuildwheel by default builds
for both CPython and PyPy, and PyPy 3.8/3.9/3.10 don't have the
PyModule_GetFilenameObject and other C API symbols that pybind11
requires:
/tmp/.../pybind11/pybind11.h:1652:28: error:
'PyModule_GetFilenameObject' was not declared in this scope
CPython cp38 through cp313 all built successfully. PyPy support for
pybind11 is not a goal of this project, so skip the PyPy targets
entirely instead of trying to patch around upstream gaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.1.0 release workflow failed because cibuildwheel defaults to building both CPython and PyPy, and PyPy lacks the C API symbols pybind11 expects (
PyModule_GetFilenameObject, etc.). All 6 CPython targets (cp38–cp313) built fine — only the 3 PyPy targets failed, and that fail-fast'd the whole job, so PyPI never received the wheels.This adds
CIBW_SKIP: "pp*"to the release wheel build step. PyPy support for pybind11 native extensions is not a goal of this project, so skipping is the right move (rather than patching around upstream gaps).After this merges
I will re-create the v1.1.0 GitHub Release at the new master HEAD; that re-fires the publish workflow, which now skips PyPy and uploads CPython wheels + sdist to PyPI.
Test plan
CIBW_BUILD: "cp310-*") keeps working unchanged