feat(memo): create memos on the selected calendar date#5925
Conversation
When a date is active in the activity calendar, the home memo editor now seeds the new memo's createTime/updateTime to that date and reveals the existing TimestampPopover so the user can adjust before saving. Empty in-month calendar cells also become clickable so users can start the first memo for an empty day. - Add `deriveDefaultCreateTimeFromFilters` helper that turns the active `displayTime` filter into a Date (selected local date + current local hh:mm:ss), with defensive parsing. - Drop the `count > 0` gate in CalendarCell so empty in-month cells render as buttons; out-of-month cells stay non-interactive. - Add `defaultCreateTime?: Date` prop on MemoEditor; in create mode, useMemoInit seeds timestamps from the prop and a useEffect re-syncs whenever the prop changes (live-derived from the calendar filter). Edit mode and the comment editor are unaffected by construction. - PagedMemoList reads MemoFilterContext at the home-editor render site and passes the derived prop. Frontend-only: the API and store layer already accept custom createTime/updateTime on CreateMemo.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA frontend-only implementation enabling memo timestamp prefilling when users click activity calendar dates. The feature derives a local-time date from an active calendar filter, makes empty calendar cells clickable, adds an optional ChangesCalendar Date Prefill Feature
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
|
@codex review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/src/components/MemoEditor/index.tsx (1)
280-284:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDate prefill is lost after the first save in the same filter session.
dispatch(actions.reset())clearsstate.timestamps, which hides theTimestampPopover(condition on line 319 becomes false). The live-syncuseEffect(lines 94–103) won't re-fire because none of its deps (defaultCreateTime,memo,isInitialized,actions,dispatch) change across the reset. Every memo after the first one typed under the samedisplayTimefilter will be saved with a server-generated "now" timestamp, silently defeating the feature for multi-memo sessions.The existing
defaultVisibilityblock immediately below already models the correct fix — re-dispatch the default after reset:🐛 Proposed fix
dispatch(actions.reset()); if (!memoName && defaultVisibility) { dispatch(actions.setMetadata({ visibility: defaultVisibility })); } + if (!memoName && defaultCreateTime) { + dispatch(actions.setTimestamps({ createTime: defaultCreateTime, updateTime: defaultCreateTime })); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/MemoEditor/index.tsx` around lines 280 - 284, Resetting the editor with dispatch(actions.reset()) clears state.timestamps and hides the TimestampPopover so the live-sync useEffect (deps: defaultCreateTime, memo, isInitialized, actions, dispatch) doesn't re-run and subsequent memos lose the prefetched date; mirror the existing defaultVisibility fix by re-dispatching the default create-time after the reset (i.e., after dispatch(actions.reset()) call, call the corresponding action to restore timestamps/createTime using defaultCreateTime so state.timestamps is repopulated and TimestampPopover remains visible for the next memo).
🧹 Nitpick comments (1)
web/tests/derive-default-create-time.test.ts (1)
54-69: ⚡ Quick winAdd unconditional date-component assertions to close a coverage gap.
The only non-conditional assertion in this test is
expect(result).toBeDefined(). An implementation that ignores the filter entirely and just returnsnew Date()(today's date with today's time) would pass all assertions here:toBeDefined()passes, and the time-of-day range check would also pass because the time would trivially fall betweenbeforeandafter. The date components (2025,4,1) from the filter value"2025-05-01"are never verified on this code path.🛠️ Proposed fix
expect(result).toBeDefined(); + // Verify the date portion always comes from the filter, not from `now`. + expect(result!.getFullYear()).toBe(2025); + expect(result!.getMonth()).toBe(4); // May (0-indexed) + expect(result!.getDate()).toBe(1); // Time-of-day should fall between before and after (within 1s tolerance).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/tests/derive-default-create-time.test.ts` around lines 54 - 69, The test fails to assert that the date components from the filter are applied; update the test for deriveDefaultCreateTimeFromFilters to add unconditional assertions that result's year, month (0-based month adjustment if necessary), and day equal 2025, May (05), and 1 respectively (e.g., check result.getFullYear(), result.getMonth(), result.getDate()), while keeping the existing time-of-day range checks intact; reference the function deriveDefaultCreateTimeFromFilters and the test case in derive-default-create-time.test.ts when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@web/src/components/MemoEditor/index.tsx`:
- Around line 280-284: Resetting the editor with dispatch(actions.reset())
clears state.timestamps and hides the TimestampPopover so the live-sync
useEffect (deps: defaultCreateTime, memo, isInitialized, actions, dispatch)
doesn't re-run and subsequent memos lose the prefetched date; mirror the
existing defaultVisibility fix by re-dispatching the default create-time after
the reset (i.e., after dispatch(actions.reset()) call, call the corresponding
action to restore timestamps/createTime using defaultCreateTime so
state.timestamps is repopulated and TimestampPopover remains visible for the
next memo).
---
Nitpick comments:
In `@web/tests/derive-default-create-time.test.ts`:
- Around line 54-69: The test fails to assert that the date components from the
filter are applied; update the test for deriveDefaultCreateTimeFromFilters to
add unconditional assertions that result's year, month (0-based month adjustment
if necessary), and day equal 2025, May (05), and 1 respectively (e.g., check
result.getFullYear(), result.getMonth(), result.getDate()), while keeping the
existing time-of-day range checks intact; reference the function
deriveDefaultCreateTimeFromFilters and the test case in
derive-default-create-time.test.ts when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 97d55c2c-62a0-4bba-98de-e1c1fdc02553
📒 Files selected for processing (10)
docs/superpowers/plans/2026-05-02-calendar-date-prefill.mddocs/superpowers/specs/2026-05-02-calendar-date-prefill-design.mdweb/src/components/ActivityCalendar/CalendarCell.tsxweb/src/components/MemoEditor/hooks/useMemoInit.tsweb/src/components/MemoEditor/index.tsxweb/src/components/MemoEditor/types/components.tsweb/src/components/MemoEditor/utils/deriveDefaultCreateTime.tsweb/src/components/PagedMemoList/PagedMemoList.tsxweb/tests/calendar-cell-empty-clickable.test.tsxweb/tests/derive-default-create-time.test.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7eed86409c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…s keep date After dispatch(actions.reset()), state.timestamps was wiped and the live-sync useEffect didn't re-fire (its deps don't change across reset), so memo #2+ in the same calendar-filter session silently fell back to server-generated "now". Mirror the existing defaultVisibility re-seed pattern. Also tighten the "uses real new Date()" test to assert the date components come from the filter — previously it would have passed an impl that returned new Date() and ignored filters entirely.
1 participant
When a date is active in the activity calendar, the home memo editor now seeds the new memo's createTime/updateTime to that date and reveals the existing TimestampPopover so the user can adjust before saving. Empty in-month calendar cells also become clickable so users can start the first memo for an empty day.
deriveDefaultCreateTimeFromFiltershelper that turns the activedisplayTimefilter into a Date (selected local date + current local hh:mm:ss), with defensive parsing.count > 0gate in CalendarCell so empty in-month cells render as buttons; out-of-month cells stay non-interactive.defaultCreateTime?: Dateprop on MemoEditor; in create mode, useMemoInit seeds timestamps from the prop and a useEffect re-syncs whenever the prop changes (live-derived from the calendar filter). Edit mode and the comment editor are unaffected by construction.Frontend-only: the API and store layer already accept custom createTime/updateTime on CreateMemo.