Refactor Toast methods to allow nullable title parameter#632
Open
dirk-helbert wants to merge 1 commit intousernotnull:mainfrom
Open
Refactor Toast methods to allow nullable title parameter#632dirk-helbert wants to merge 1 commit intousernotnull:mainfrom
dirk-helbert wants to merge 1 commit intousernotnull:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Toastclass to improve type safety and consistency for the optionaltitleparameter in its notification methods. All relevant methods now explicitly declare thetitleparameter as nullable, aligning with modern PHP best practices.Type consistency improvements:
titleparameter type fromstring $title = nullto?string $title = nullin the following methods:danger,debug,info,success, andwarning. This ensures proper handling of cases where no title is provided. [1] [2]