Adding back code-highlight to blog post, tweaked performance issue with scrolling.#569
Adding back code-highlight to blog post, tweaked performance issue with scrolling.#569juancabrera wants to merge 2 commits intomasterfrom
Conversation
Finally, the language support: I guess, @andydutch, this could be a feature to implement - some way to choose the language for each block in WP. At the moment the automatic detection is useless and I don't think we can justify the introduction of syntax highlighting unless we solve it. What do you think? |
|
@phil-linnell agree with you. Do you think that lower down the throttle to maybe @andydutch let us know what you think! and how we can help to make this happen. |
…o added throttle to the main scroll listener
066004f to
a7bf5c5
Compare
…n post and caseStudy instead
|
@juancabrera Changing the throttle to 100ms didn't help. Based on my thoughts about performance elsewhere in the app, I thought maybe just to return to no throttling, and instead remove the listener on post and caseStudy pages. What do you think? |
|
@phil-linnell gotcha. about the listener, when I chatted with casey and fredrik one of the most useful things of the listener was to know if people finished (or how far read) the blog post. So based on that it should be on the post page. In fact, I tried removing it and works like a sharm. they were open to change or other options, so let me check with them again. Other way to get a sense of how much the people reads the blogpost is by how much time they spent on the post. will get back to you asap. |
This PR covers:
throttleof 240ms to main onScroll event listener to help with performance.Notes: