Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
=========================================
+ Coverage 0 98.19% +98.19%
=========================================
Files 0 370 +370
Lines 0 110261 +110261
Branches 0 2066 +2066
=========================================
+ Hits 0 108266 +108266
- Misses 0 1995 +1995 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Restores and modernizes GitHub Actions CI workflows across Windows, Ubuntu, and macOS while updating supporting build tooling and submodules (resolves #928).
Changes:
- Updated CI workflows to newer runner images, action versions, and Python 3.12 setup; added Codecov coverage collection.
- Updated CMake minimum required version and fixed
CodeCoverage.cmakecustom target/command definitions. - Updated
pybind11anddoctestsubmodule pointers; removed legacy Semgrep and CodeQL workflows (and effectively disabled SonarCloud).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| Libraries/pybind11 | Bumps pybind11 submodule commit to a newer revision. |
| Libraries/doctest | Bumps doctest submodule commit to a newer revision. |
| CMakeLists.txt | Raises minimum required CMake version. |
| Builds/CMake/CodeCoverage.cmake | Fixes missing COMMAND entries and replaces no-op post-build commands with informative echo. |
| .github/workflows/windows.yml | Refreshes Windows CI (new runner targets, checkout/msbuild versions, Python setup, solution selection). |
| .github/workflows/ubuntu.yml | Refreshes Ubuntu CI (Ubuntu 24.04 matrix, newer compiler versions, Python setup). |
| .github/workflows/macos.yml | Refreshes macOS CI matrix and Python setup; changes runner targets significantly. |
| .github/workflows/ubuntu-codecov.yml | Updates Codecov workflow, captures LCOV report, and updates Codecov action. |
| .github/workflows/ubuntu-sonarcloud.yml | Comments out SonarCloud workflow content (effectively disables it). |
| .github/workflows/semgrep.yml | Removes Semgrep workflow. |
| .github/workflows/codeql-analysis.yml | Removes CodeQL workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision includes: