Took TideGear's changes, removed the device/controller implementation…#1584
Draft
utkarshdalal wants to merge 1 commit into
Draft
Took TideGear's changes, removed the device/controller implementation…#1584utkarshdalal wants to merge 1 commit into
utkarshdalal wants to merge 1 commit into
Conversation
… (we vibrate the controller first and then the device), and made the rumble more efficient
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (we vibrate the controller first and then the device), and made the rumble more efficient
Description
Recording
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Makes rumble persistent and smoother, and adds a per‑container vibration intensity control. We now vibrate the controller first and fall back to the device, and re‑arm rumble so it doesn’t cut off early.
New Features
PrefManager,ContainerData, and extras, and applied throughWinHandler.setVibrationIntensity.Performance
evshimkeepalive re‑applies the last rumble viaSDL_JoystickRumbleto prevent the ~1s auto‑stop; sleeps when idle and avoids echoing keepalive updates back into shared memory.WinHandlerkeepalive refreshes one‑shot vibrations without busy polling and cancels cleanly on shutdown to prevent lingering buzz.Written for commit 4b2be67. Summary will update on new commits.