Created FramPacingLogger.java for debugging#1631
Draft
Catpotatos wants to merge 1 commit into
Draft
Conversation
Added frame logging every 10sec that can be enabled by using GN_FRAME_LOG = 1 for debug purposes in container settings Anchored the logger into every frame-producing, frame-pacing, and frame-limiting path. All edits outside FramePacingLogger.java are purely additive logging anchors The frame report will show how frames are getting output and which rendering path is being used
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
I'll wait for the FSR changes to be fully out so that I can reanchor to upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created FramPacingLogger.java for debugging
Added frame logging every 10sec that can be enabled by using GN_FRAME_LOG = 1 for debug purposes in container settings
Anchored the logger into every frame-producing, frame-pacing, and frame-limiting path. All edits outside FramePacingLogger.java are purely additive logging anchors
The frame report will show how frames are getting output and which rendering path is being used
Recording
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Adds a new frame pacing diagnostics logger that reports frame sources, limits, and on-screen FPS every 10s to logcat. This helps debug judder and understand which rendering path is active; opt-in via GN_FRAME_LOG=1.
New Features
com.winlator.renderer.FramePacingLoggerwith a 10s report (tag: "FramePacing", 10s initial delay).PresentExtension,VulkanRenderer,GLRenderer,ASurfaceRenderer,VortekRendererComponent,FrameRating, andXServerScreen(purely additive).Migration
Written for commit 7c39b3d. Summary will update on new commits.