Stream Arrow RecordBatches using mpsc channel and tokio_streams#481
Merged
domoritz merged 1 commit intouwdata:dom/rust-streamfrom Aug 14, 2024
Merged
Conversation
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation of #462 by using an mpsc channel and tokio_streams.
The reason this is more complicated that what you were trying @domoritz , is that the
Arrowtype provided by the duckdb crate is not Send. This means that it (and objects that depend on it) cannot be transferred across threads. This is why it doesn't work to build a stream using thestream!macro and return it from inside theconn.interactclosure.Using mpsc channels like I am here is a common workaround for dealing with non-send objects. Here the Arrow object stays in the thread that constructed it, and pushes the record batches through the channel back to the main thread. This channel is wrapped into a stream using the
ReceiverStreamfrom thetokio_streamcrate.I didn't actually test this, just got it compiling, so give it a try and see if it works the way you want.