Skip to content

chore: add prettier #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theVedanta wants to merge 13 commits into
base: main
Choose a base branch
from
Open

chore: add prettier #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3be879a
prettier
theVedanta Dec 24, 2025
11c5578
eslint + dev dep + printwidth + ignore schema-files
theVedanta Jan 7, 2026
0f1bc65
test ci
theVedanta Jan 7, 2026
3880433
lock
theVedanta Jan 7, 2026
c6ee681
Merge branch 'main' into prettierrc
theVedanta Jan 7, 2026
6c8e7eb
eslint-flat
theVedanta Jan 7, 2026
3018b44
deps
theVedanta Jan 7, 2026
c5e4f42
write script
theVedanta Jan 8, 2026
680a8db
format, lint:fix, format:check & Bumped up eslint-config-prettier to …
theVedanta Jan 9, 2026
f96c15d
printwidth improve + es5 trailing comma
theVedanta Jan 9, 2026
983717a
lock
theVedanta Jan 11, 2026
be04196
@ts-ignore switched out; eslint-disable-next-line for overflowing lin…
theVedanta Jan 14, 2026
d6800b0
merge
theVedanta Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Schema files
specs/**
docs/public/specs/**
docs/public/schema/**
packages/vgplot/spec/dist/mosaic-schema.json

7 changes: 7 additions & 0 deletions .prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "es5",
"printWidth": 100,
"arrowParens": "avoid"
}
3 changes: 2 additions & 1 deletion bin/publish-schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import { copyFile, readFile, symlink, unlink } from 'node:fs/promises';
async function link(schemaFile, linkFile) {
try {
await unlink(linkFile);
} catch (err) { // eslint-disable-line @typescript-eslint/no-unused-vars
// eslint-disable-next-line
Copy link
Member

@domoritz domoritz Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed anymore.

Copy link
Member

@domoritz domoritz Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the rest as well. We should probably have something like

export default tseslint.config({
  rules: {
    // Note: you must disable the base rule as it can report incorrect errors
    "no-unused-vars": "off",
    "@typescript-eslint/no-unused-vars": "error"
  }
});

} catch (err) { // @typescript-eslint/no-unused-vars
// file may not have existed
}
await symlink(schemaFile, linkFile);
Expand Down
4 changes: 3 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import js from '@eslint/js';
import tseslint from 'typescript-eslint';
import globals from 'globals';
import eslintConfigPrettier from 'eslint-config-prettier/flat';

/** @type {import('@types/eslint').Linter.Config[]} */
export default tseslint.config(
Expand All @@ -27,5 +28,6 @@ export default tseslint.config(
"@typescript-eslint/no-this-alias": "warn",
"@typescript-eslint/ban-ts-comment": "warn"
},
}
},
eslintConfigPrettier
);
Loading
Loading