Open
Conversation
domoritz
reviewed
Feb 7, 2026
theVedanta
force-pushed
the
npm-to-pnpm
branch
from
d20ceb0 to
cb6fc6a
Compare
domoritz
approved these changes
Mar 3, 2026
Member
domoritz
left a comment
domoritz
left a comment
There was a problem hiding this comment.
That you. Just two changes and then we can merge.
| "type": "git", | ||
| "url": "https://github.com/uwdata/mosaic.git" | ||
| }, | ||
| "packageManager": "pnpm@10.5.2", |
Member
There was a problem hiding this comment.
I think we should allow more than one specific version.
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: "10.5.2" |
Member
There was a problem hiding this comment.
This is already outdated. Let's use latest here. We will notice early if things break then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply replaces npm (package-lock) with pnpm (pnpm-lock) and adds a workspace.yaml file