Skip to content

Refactor and test#26

Open
james-tindal wants to merge 90 commits intouxiew:mainfrom
james-tindal:refactor-and-test
Open

Refactor and test#26
james-tindal wants to merge 90 commits intouxiew:mainfrom
james-tindal:refactor-and-test

Conversation

@james-tindal
Copy link
Contributor

@james-tindal james-tindal commented Dec 17, 2025

testing/refactoring:

  • added snapshot tests to detect regressions in the cli output
  • separated logic from io enable fast unit tests
  • mock network to test localize fast
  • made some types more accurate
  • re-organised for understandability
  • temporary test files stored outside the repository

bugs fixed:

  • outputting empty files
  • unzip command never outputting anything
  • numbering
    • progress logs not always using consecutive numbers staring from 1
    • file numbers not always using consecutive numbers starting from 1
    • progress log numbers not always matching the file number

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@james-tindal james-tindal force-pushed the refactor-and-test branch 4 times, most recently from 8c18197 to f811592 Compare December 17, 2025 02:32
@uxiew
Copy link
Owner

uxiew commented Dec 17, 2025

You're amazing! Thank you.I'll look into it.

@Ryson-32
Copy link

牛逼

@Limit4579
Copy link

牛b

@lushengbai
Copy link

Open source wouldn’t be the same without contributors like you.

@vuejshub
Copy link

🔥🔥🔥 This is amazing!

@nothingly
Copy link

牛逼!!

@HarrisonLS
Copy link

fantastic baby!!

@litian-98
Copy link

牛逼

@yd-ccccai
Copy link

you're amazing

@uvrr
Copy link

uvrr commented Dec 17, 2025

Thank you for your contributions to the open source project.

@hzxcaq
Copy link

hzxcaq commented Dec 17, 2025

Awesome!

@zc5514
Copy link

zc5514 commented Dec 17, 2025

Open source wouldn’t be the same without contributors like you.

@WnoteZZ
Copy link

WnoteZZ commented Dec 17, 2025

antastic baby!!

@z1gui
Copy link

z1gui commented Dec 17, 2025

hahaha,good job,baby!

@dinghen
Copy link

dinghen commented Dec 17, 2025

oh bro so amazing!!!!!

@h7ml
Copy link

h7ml commented Dec 17, 2025

That's so cool, man. You did something really cool.

fixes a discrepancy between local and CI
@james-tindal
Copy link
Contributor Author

james-tindal commented Dec 17, 2025

Thanks for the kind words everyone! 😀

@james-tindal
Copy link
Contributor Author

james-tindal commented Dec 17, 2025

Currently the localize test is failing due to a slow image server. I'm going to change the test to mock the network.

@fcanlnony
Copy link

awesome work !!!!!!!!!😯

@daysdays
Copy link

daysdays commented Dec 18, 2025

you are nice guy ! awesome good job .

@james-tindal
Copy link
Contributor Author

james-tindal commented Dec 19, 2025

@uxiew
It's passing now.

I also made all tests use subdirectories of a common temporary directory that is deleted at the end and start of every test run so the tests don't have to include code for deleting temporary files.

I could cut this PR into smaller chunks if that makes things easier.

@uxiew
Copy link
Owner

uxiew commented Dec 21, 2025

@james-tindal

I could cut this PR into smaller chunks if that makes things easier.

That would be highly appreciated — if you’re able to split this into smaller, focused chunks, I’ll be able to review and merge it with much more confidence.

I’m comfortable with the direction of the changes now, and once the commits are reasonably structured, I should be able to merge without concerns.

Thank you very much for your efforts and the solid work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.