Conversation
|
|
8c18197 to
f811592
Compare
|
You're amazing! Thank you.I'll look into it. |
|
牛逼 |
|
牛b |
|
Open source wouldn’t be the same without contributors like you. |
|
🔥🔥🔥 This is amazing! |
|
牛逼!! |
|
fantastic baby!! |
|
牛逼 |
|
you're amazing |
|
Thank you for your contributions to the open source project. |
|
Awesome! |
|
Open source wouldn’t be the same without contributors like you. |
|
antastic baby!! |
|
hahaha,good job,baby! |
|
oh bro so amazing!!!!! |
|
That's so cool, man. You did something really cool. |
was a text file, not a real epub
allows importing esm modules (e.g. package-directory) shows more actionable error messages less liable to blowing up handles typescript without an external helper
9a717d3 to
70fee80
Compare
fixes a discrepancy between local and CI
70fee80 to
3750b1c
Compare
|
Thanks for the kind words everyone! 😀 |
|
Currently the localize test is failing due to a slow image server. I'm going to change the test to mock the network. |
|
awesome work !!!!!!!!!😯 |
|
you are nice guy ! awesome good job . |
|
@uxiew I also made all tests use subdirectories of a common temporary directory that is deleted at the end and start of every test run so the tests don't have to include code for deleting temporary files. I could cut this PR into smaller chunks if that makes things easier. |
That would be highly appreciated — if you’re able to split this into smaller, focused chunks, I’ll be able to review and merge it with much more confidence. I’m comfortable with the direction of the changes now, and once the commits are reasonably structured, I should be able to merge without concerns. Thank you very much for your efforts and the solid work on this PR. |
testing/refactoring:
bugs fixed: