Conversation
Co-authored-by: Robert Cohn <rscohn2@gmail.com>
Head branch was pushed to by a user without write access
rscohn2
left a comment
rscohn2
left a comment
There was a problem hiding this comment.
Sorry. I did not notice the lack of indentation in the first review. Unindented line ends a code block, and there must be a blank line before that.
| .. code:: cpp | ||
|
|
||
| template<class BufferType> | ||
| event ccl::allgather(const BufferType* send_buf, |
There was a problem hiding this comment.
| event ccl::allgather(const BufferType* send_buf, | |
| event ccl::allgather(const BufferType* send_buf, |
And following lines need to be indented
| const allgather_attr& attr = default_allgather_attr, | ||
| const vector_class<event>& deps = {}); | ||
|
|
||
| event ccl::allgather(const void* send_buf, |
| const broadcast_attr& attr = default_broadcast_attr, | ||
| const vector_class<event>& deps = {}); | ||
| template <class BufferType> | ||
| event ccl::broadcast(BufferType*send_buf, |
There was a problem hiding this comment.
Since this is a new file, it needs to be added to the table of contents in operations.rst
|
I pushed some changes to your branch. I believe I fixed the formatting issues as noted in the comments. If you want to make more changes, you need to sync with the repo in github with my changes. One way to do it is to do a fresh clone of your repo and checkout the branch. |
| The buffer to store gathered result of BufferTuype, must be large enough to hold values from all ranks, i.e., size should be equal do BufferType * send_count | ||
|
|
||
| send_count | ||
| The number of elements of type BufferType in send_buf |
There was a problem hiding this comment.
Here and a few other places you used unicode (non breaking space). You cannot use unicode directly.
3 participants
No description provided.