[oneMath][RNG] Added random engine adaptors#616
Merged
andreyfe1 merged 6 commits intouxlfoundation:mainfrom Apr 1, 2025
Merged
[oneMath][RNG] Added random engine adaptors#616andreyfe1 merged 6 commits intouxlfoundation:mainfrom
andreyfe1 merged 6 commits intouxlfoundation:mainfrom
Conversation
Signed-off-by: Fedorov, Andrey <andrey.fedorov@intel.com>
3 tasks
aelizaro
reviewed
Mar 26, 2025
| ==================== | ||
|
|
||
| ``count_engine_adaptor`` is a random number engine adaptor that counts how many | ||
| random numbers were taken from an engine during the ``generate`` call. |
Contributor
There was a problem hiding this comment.
Should we specify what is meant by random number here: if it is 32-bit generator output or something else? As different engines may provide different bits output.
Possible suggestions:
- how many times 32 random bits were taken from the engine
- how many times the random engine state is advanced
- introduce public operator() or generate() for engine and count its calls
Contributor
Author
There was a problem hiding this comment.
I like the option how many times 32 random bits were taken from the engine or how many times the random engine state is advanced, but still don't see the best option to write. Will think about it
aelizaro
approved these changes
Apr 1, 2025
aelizaro
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New engine adaptor is added. It wraps a random engine to add extra functionality: to query how many random numbers were taken from an engine during the
generatecall.Feel free to provide your feedback.