fixes for 2026.0 compiler by Alexandr-Solovev · Pull Request #3476 · uxlfoundation/oneDAL

Alexandr-Solovev · 2026-01-14T14:24:19Z

PR Description

Summary

This PR updates SYCL code to remove deprecated features and improve compatibility with recent compiler versions.

Changes

Replacement of deprecated address_space
- Replaced usage of
```
sycl::access::address_space::ext_intel_global_device_space
```
  with
```
sycl::access::address_space::global_space
```
- Reason: ext_intel_global_device_space has been removed in recent compiler versions.

Update of binary operations with is_logical flag

For all operations like:

template <typename T>
struct logical_or {
    using tag_t = reduce_binary_op_tag;
    constexpr static inline T init_value = false;
    using acc_t = T;
};

Added is_logical flag and updated init_value to T(false)
Purpose: Ensure compatibility with
```
sycl::reduce_over_group(it.get_group(), local_accum, binary.native);
```
so that the binary operation matches the type of the return value during reduction.

Removal of old compiler version checks
- Removed blocks like:
```
#if __SYCL_COMPILER_VERSION >= 20230828
```

Notes

All changes are backward compatible with current SYCL standards.
No behavioral changes; only refactoring for compatibility and clarity.

Checklist:

Completeness and readability

I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
I have resolved any merge conflicts that might occur with the base branch.

Testing

I have run it locally and tested the changes extensively.
All CI jobs are green or I have provided justification why they aren't.
I have extended testing suite if new functionality was introduced in this PR.

Performance

I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

ethanglaser · 2026-01-15T19:25:30Z

Nice work on this so far! CEV job with this branch: http://intel-ci.intel.com/f0f24793-7dcb-f1ab-af3c-a4bf010d0e2d. FYI there are still fails in oneDAL build on windows and several validation jobs on linux side

cpp/oneapi/dal/backend/primitives/reduction/functors.hpp

Vika-F

Please revert this change in logical_or, wait for the CI results and LGTM.

constexpr static inline auto native = [](const T& a, const T& b) {
    return static_cast<T>(std::logical_or<T>{}(a, b));
};

ethanglaser · 2026-01-23T19:03:38Z

Please share the latest CEV run from this branch. Also please address clang-format before merging

ethanglaser · 2026-01-23T19:12:59Z

cpp/oneapi/dal/backend/primitives/reduction/functors.hpp

    constexpr static inline sycl::logical_or<T> native{};
 #else
    constexpr static inline std::logical_or<T> native{};
-};


Confused how this file compiled with an extra } in here?

I guess it was under #else branch and was never built.

Copilot

Pull request overview

This PR updates SYCL code to remove deprecated compiler features and improve compatibility with the 2026.0 compiler version.

Changes:

Replaced deprecated ext_intel_global_device_space with global_space in atomic operations
Updated logical_or binary operations to use bool accumulator type instead of float/double
Removed compiler version checks (#if __SYCL_COMPILER_VERSION >= ...) for obsolete fallback code
Updated MKL SYCL library symlinks from version 5 to version 6

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
dev/bazel/deps/mkl.tpl.BUILD	Updated MKL SYCL library symlinks from .so.5 to .so.6
dev/bazel/deps/mkl.bzl	Updated MKL SYCL library symlinks from .so.5 to .so.6
cpp/oneapi/dal/backend/primitives/reduction/functors.hpp	Fixed `logical_or` init_value and replaced deprecated address space
cpp/oneapi/dal/backend/atomic.hpp	Replaced deprecated `ext_intel_global_device_space` with `global_space`
cpp/oneapi/dal/backend/primitives/reduction/*.cpp	Added `AccT` template parameter for accumulator type in reduction operations
cpp/oneapi/dal/backend/primitives/selection/*.cpp	Removed obsolete compiler version checks
cpp/oneapi/dal/algo//backend/gpu/.cpp	Replaced deprecated address space and removed compiler version checks

cpp/oneapi/dal/backend/primitives/reduction/test/reduction_rm_uniform_dpc.cpp

Copilot · 2026-02-04T09:29:14Z

cpp/oneapi/dal/backend/primitives/reduction/test/reduction_rm_random_dpc.cpp


    array<float_t> groundtruth_cw() const {
-        auto res = array<float_t>::full(width_, binary_.init_value);
+        auto res = array<float_t>::full(width_, static_cast<float_t>(binary_.init_value));


The explicit cast static_cast<float_t>(binary_.init_value) is needed because binary_.init_value is now of type bool for logical_or operations. Consider documenting this cast requirement to clarify why the conversion is necessary for future maintainers.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 8 comments.

Copilot · 2026-02-10T08:54:37Z

cpp/oneapi/dal/backend/primitives/selection/select_indexed_dpc.cpp

@@ -102,7 +102,6 @@ sycl::event select_indexed_local(sycl::queue& q,
                                        ? (bid + 1) * block
                                        : src_count;
            sycl::global_ptr<const Type> global((const Type*)(src_ptr + from));


global is now unused after removing the #else branch. Please remove this variable (or use it in the async_work_group_copy call) to avoid unused-variable warnings that can break builds when warnings are treated as errors.

Suggested change

sycl::global_ptr<const Type> global((const Type*)(src_ptr + from));

Copilot · 2026-02-10T08:54:38Z

cpp/oneapi/dal/backend/primitives/reduction/reduction_rm_cw_naive_local_dpc.cpp

        sycl::local_ptr<const Float> local(
            (const Float*)cache_.template get_multi_ptr<sycl::access::decorated::yes>().get_raw());
-#else
-        sycl::local_ptr<const Float> local((const Float*)cache_.get_pointer().get());
-#endif
-        Float acc = (override_init_ || (loc_idx != 0)) ? //
-                        binary_.init_value
-                                                       : output_[col_idx];
+        AccT acc = (override_init_ || (loc_idx != 0)) ? //
+                       binary_.init_value


After removing the compiler-version branches, both local (lines 50-51) and global (line 58) are no longer used. Please remove these variables or update the copy call to use them, to avoid unused-variable warnings.

Copilot · 2026-02-10T08:54:38Z

cpp/oneapi/dal/backend/primitives/reduction/reduction_rm_cw_naive_local_dpc.cpp

            sycl::global_ptr<const Float> global(from);
            const auto count =
                sycl::min(static_cast<std::int32_t>(lm), static_cast<std::int32_t>(height_ - j));
-#if __SYCL_COMPILER_VERSION >= 20230828
            it.async_work_group_copy(
                  cache_.template get_multi_ptr<sycl::access::decorated::yes>(),
                  sycl::address_space_cast<sycl::access::address_space::global_space,
                                           sycl::access::decorated::yes>(from),
                  count,
                  lstride_)
                .wait();


After removing the compiler-version branches, both local (lines 50-51) and global (line 58) are no longer used. Please remove these variables or update the copy call to use them, to avoid unused-variable warnings.

Copilot · 2026-02-10T08:54:38Z

dev/bazel/deps/mkl.bzl

+        "lib/libmkl_sycl_blas.so.6",
+        "lib/libmkl_sycl_lapack.so.6",
+        "lib/libmkl_sycl_sparse.so.6",
+        "lib/libmkl_sycl_dft.so.6",
+        "lib/libmkl_sycl_vm.so.6",
+        "lib/libmkl_sycl_rng.so.6",
+        "lib/libmkl_sycl_stats.so.6",
+        "lib/libmkl_sycl_data_fitting.so.6",


Hard-coding MKL SYCL SONAMEs to .so.6 can make Bazel builds fail on environments that still ship .so.5 (or that only provide the unversioned .so symlinks). Consider relying on the unversioned .so entries only, or making the versioned entries tolerant (e.g., via conditional selection, repository variants, or a single canonical SONAME) so the dependency is not tied to a specific MKL major at build time.

Suggested change

"lib/libmkl_sycl_blas.so.6",

"lib/libmkl_sycl_lapack.so.6",

"lib/libmkl_sycl_sparse.so.6",

"lib/libmkl_sycl_dft.so.6",

"lib/libmkl_sycl_vm.so.6",

"lib/libmkl_sycl_rng.so.6",

"lib/libmkl_sycl_stats.so.6",

"lib/libmkl_sycl_data_fitting.so.6",

Copilot · 2026-02-10T08:54:38Z

cpp/oneapi/dal/backend/primitives/reduction/reduction_rm_rw_dpc.hpp

+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>
 class kernel_reduction_rm_rw_wide;

-template <typename Float, typename BinaryOp, typename UnaryOp>
+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>


Introducing AccT as a required template parameter for these primitives increases the surface area for callers and can cause churn where the accumulator is simply Float. Consider giving AccT a default (e.g., typename AccT = Float) to preserve existing instantiation patterns and simplify usage, while still allowing bool accumulators for logical reductions.

Copilot · 2026-02-10T08:54:38Z

cpp/oneapi/dal/backend/primitives/reduction/reduction_rm_rw_dpc.hpp

+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>
 class kernel_reduction_rm_rw_blocking;

-template <typename Float, typename BinaryOp, typename UnaryOp>
+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>


Introducing AccT as a required template parameter for these primitives increases the surface area for callers and can cause churn where the accumulator is simply Float. Consider giving AccT a default (e.g., typename AccT = Float) to preserve existing instantiation patterns and simplify usage, while still allowing bool accumulators for logical reductions.

Copilot · 2026-02-10T08:54:39Z

cpp/oneapi/dal/backend/primitives/reduction/reduction_rm_rw_dpc.hpp

+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>
 class kernel_reduction_rm_rw_narrow;

-template <typename Float, typename BinaryOp, typename UnaryOp>
+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>


Introducing AccT as a required template parameter for these primitives increases the surface area for callers and can cause churn where the accumulator is simply Float. Consider giving AccT a default (e.g., typename AccT = Float) to preserve existing instantiation patterns and simplify usage, while still allowing bool accumulators for logical reductions.

Copilot · 2026-02-10T08:54:39Z

cpp/oneapi/dal/backend/primitives/reduction/reduction_rm_rw_dpc.hpp

 };

-template <typename Float, typename BinaryOp, typename UnaryOp>
+template <typename Float, typename AccT, typename BinaryOp, typename UnaryOp>


Introducing AccT as a required template parameter for these primitives increases the surface area for callers and can cause churn where the accumulator is simply Float. Consider giving AccT a default (e.g., typename AccT = Float) to preserve existing instantiation patterns and simplify usage, while still allowing bool accumulators for logical reductions.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-10T17:19:06Z

cpp/oneapi/dal/backend/primitives/reduction/functors.hpp

 struct logical_or {
    using tag_t = reduce_binary_op_tag;
-    constexpr static inline T init_value = false;
+    constexpr static inline T init_value = T(false);


The logical_or struct is parameterized by type T, but logical OR operations should only work with boolean types. The init_value should be false (without cast), and T should be constrained to bool. The current implementation allows instantiation with non-boolean types (like float or double), which is semantically incorrect for logical operations.

Alexandr-Solovev added 4 commits January 14, 2026 06:23

fixes

5a8f662

fixes

1490c46

fixes

5365d4f

fixes

a75c1c6

Alexandr-Solovev changed the title ~~fixes~~ fixes for 2026.0 compiler Jan 15, 2026

Alexandr-Solovev added 2 commits January 15, 2026 06:20

fixes

e0ba418

fixes

321e6c4

Alexandr-Solovev added the dependencies Pull requests that update a dependency file label Jan 15, 2026

Alexandr-Solovev marked this pull request as ready for review January 15, 2026 16:04

Alexandr-Solovev requested review from avolkov-intel, david-cortes-intel, ethanglaser and icfaust as code owners January 15, 2026 16:04

Vika-F reviewed Jan 16, 2026

View reviewed changes

cpp/oneapi/dal/backend/primitives/reduction/functors.hpp Outdated Show resolved Hide resolved

Alexandr-Solovev added 4 commits January 21, 2026 08:57

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

d5bee25

fixes

c92c69d

fixes

1c473b3

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

c975091

Vika-F approved these changes Jan 22, 2026

View reviewed changes

Alexandr-Solovev added 3 commits January 22, 2026 05:49

fixes

be9b145

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

76d903b

fixes

404342b

ethanglaser approved these changes Jan 23, 2026

View reviewed changes

Alexandr-Solovev added 4 commits January 26, 2026 03:55

fixes

83a9b28

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

3d838ad

fixes

5350fde

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

ecec002

Copilot AI review requested due to automatic review settings February 4, 2026 09:28

Copilot AI reviewed Feb 4, 2026

View reviewed changes

Alexandr-Solovev added 2 commits February 4, 2026 05:50

fixes

8262d15

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

0320581

Copilot AI review requested due to automatic review settings February 10, 2026 08:51

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Alexandr-Solovev added 2 commits February 10, 2026 09:10

re-enable dpl for all gpu

d6783fe

fixes

229f8d1

Copilot AI review requested due to automatic review settings February 10, 2026 17:18

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Merge branch 'main' into dev/asolovev_fixes_compiler_2026

1974c3c

Comments

Conversation

Alexandr-Solovev commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Summary

Changes

Notes

Uh oh!

ethanglaser commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Vika-F left a comment

Choose a reason for hiding this comment

Uh oh!

ethanglaser commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ethanglaser Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Alexandr-Solovev Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alexandr-Solovev commented Jan 14, 2026 •

edited

Loading

ethanglaser commented Jan 15, 2026 •

edited

Loading

ethanglaser commented Jan 23, 2026 •

edited

Loading