ENH: Ridge Regression CPU SPMD support#3506
Draft
DDJHB wants to merge 1 commit intouxlfoundation:mainfrom
Draft
Conversation
Contributor
Author
|
/intelci: run |
| } | ||
|
|
||
| TEMPLATE_LIST_TEST_M(lr_spmd_test, "RR common flow", "[rr][spmd]", lr_types) { | ||
| SKIP_IF(this->not_float64_friendly()); |
Contributor
There was a problem hiding this comment.
Why would it need to skip this one if it's on CPU?
Contributor
There was a problem hiding this comment.
This test is common for CPU and GPU and this check is necessary just for GPU without native float64 support
Contributor
There was a problem hiding this comment.
@DDJHB @Alexandr-Solovev it would be better to add if_gpu condition then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO
Checklist:
Completeness and readability
Testing
Performance