Draft
Conversation
Contributor
Author
|
/intelci: run |
Vika-F
reviewed
Feb 11, 2026
| // Simple allreduce of centered crossproducts is incorrect because each | ||
| // rank uses its local mean. Un-center before allreduce, then re-center | ||
| // with global statistics after. | ||
| if (!desc.get_assume_centered()) { |
Contributor
There was a problem hiding this comment.
Will it be simpler to use DAAL's Distributed<step2Master> algorithm for aggregation?
https://github.com/uxlfoundation/oneDAL/blob/main/samples/daal/cpp/mpi/sources/covariance_dense_distributed_mpi.cpp#L106
Contributor
Author
There was a problem hiding this comment.
Interesting suggestion, will look into this
Vika-F
reviewed
Feb 13, 2026
| /// property value | ||
| compute_input(const table& data); | ||
|
|
||
| virtual ~compute_input() = default; |
Contributor
There was a problem hiding this comment.
What is the reason of this change?
I see that it breaks the ABI, but were there any problems due to the lack of destructor definition in this and the partial_compute_input classes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO
Checklist:
Completeness and readability
Testing
Performance