MAINT: Stronger check for dpctl availability#3102
MAINT: Stronger check for dpctl availability#3102david-cortes-intel merged 2 commits intouxlfoundation:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
icfaust
left a comment
There was a problem hiding this comment.
with the dpctl tensor removal #3091, the function is_dpctl_available is now only used here, with the result used in in test fixtures. I think this warrants a rewrite at line 64 to a try catch statement which will more elegantly solve what is required here. And then possibly moving this as a test fixture (conftest.py perhaps?). This will improve maintainability and clarity. @david-cortes-intel @avolkov-intel @ethanglaser
Removed the function. |
|
/intelci: run |
Description
Makes a stronger check for availability of DPCTL, by trying to import the queue class from it. Should make it throw more informative errors in cases in which dpctl is installed but somehow not working, or in which there is a local folder named 'dpctl' in the workspace.
Checklist:
Completeness and readability
Testing