Skip to content

MAINT: Stronger check for dpctl availability#3102

Merged
david-cortes-intel merged 2 commits intouxlfoundation:mainfrom
david-cortes-intel:dpctl_import_err
Apr 9, 2026
Merged

MAINT: Stronger check for dpctl availability#3102
david-cortes-intel merged 2 commits intouxlfoundation:mainfrom
david-cortes-intel:dpctl_import_err

Conversation

@david-cortes-intel
Copy link
Copy Markdown
Contributor

Description

Makes a stronger check for availability of DPCTL, by trying to import the queue class from it. Should make it throw more informative errors in cases in which dpctl is installed but somehow not working, or in which there is a local folder named 'dpctl' in the workspace.


Checklist:

Completeness and readability

  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 79.65% <100.00%> (+0.02%) ⬆️
github 81.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/utils/_third_party.py 90.90% <100.00%> (+2.44%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the dpctl tensor removal #3091, the function is_dpctl_available is now only used here, with the result used in in test fixtures. I think this warrants a rewrite at line 64 to a try catch statement which will more elegantly solve what is required here. And then possibly moving this as a test fixture (conftest.py perhaps?). This will improve maintainability and clarity. @david-cortes-intel @avolkov-intel @ethanglaser

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

with the dpctl tensor removal #3091, the function is_dpctl_available is now only used here, with the result used in in test fixtures. I think this warrants a rewrite at line 64 to a try catch statement which will more elegantly solve what is required here. And then possibly moving this as a test fixture (conftest.py perhaps?). This will improve maintainability and clarity. @david-cortes-intel @avolkov-intel @ethanglaser

Removed the function.

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

/intelci: run

@david-cortes-intel david-cortes-intel merged commit cb0ad39 into uxlfoundation:main Apr 9, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants