fix: check session lock in VaadinSessionScopedContext.isActive() - #499
Merged
Conversation
Accessing `@VaadinSessionScoped` beans from background threads that have a `VaadinSession` set as current but don't hold the session lock causes an `IllegalStateException` from `VaadinSession.getAttribute()`. Check `hasLock()` in `isActive()` so the scope correctly reports as inactive without the lock, producing the expected `ContextNotActiveException` instead. Fixes #495
mcollovati
marked this pull request as ready for review
April 10, 2026 09:02
TatuLund
approved these changes
Apr 22, 2026
mcollovati
enabled auto-merge (squash)
April 22, 2026 05:17
mcollovati
added a commit
that referenced
this pull request
Apr 22, 2026
) (#505) Accessing `@VaadinSessionScoped` beans from background threads that have a `VaadinSession` set as current but don't hold the session lock causes an `IllegalStateException` from `VaadinSession.getAttribute()`. Check `hasLock()` in `isActive()` so the scope correctly reports as inactive without the lock, producing the expected `ContextNotActiveException` instead. Fixes #495 Co-authored-by: Marco Collovati <marco@vaadin.com>
|
This ticket/PR has been released with Vaadin 25.1.4. |
|
This ticket/PR has been released with Vaadin 25.2.0-alpha5. |
|
This ticket/PR has been released with Vaadin 25.0.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing
@VaadinSessionScopedbeans from background threads that have aVaadinSessionset as current but don't hold the session lock causes anIllegalStateExceptionfromVaadinSession.getAttribute().Check
hasLock()inisActive()so the scope correctly reports as inactive without the lock, producing the expectedContextNotActiveExceptioninstead.Fixes #495