fix(multiaddress): Raise MaError instead of LPError on ѹ
Merged
diegomrsantos merged 9 commits intomasterfrom Sep 10, 2024
Merged
fix(multiaddress): Raise MaError instead of LPError on ѹdiegomrsantos merged 9 commits intomasterfrom
MaError instead of LPError on ѹdiegomrsantos merged 9 commits intomasterfrom
Conversation
`LPError` is the top level error type of libp2p, it makes more sense to raise a multi address specific subtype to avoid requiring callers to catch errors too broadly. As `MaError` inherits from `LPError`, existing error handlers will still work fine. Requires arnetheduck/nim-results#41
Contributor
Author
|
Nim 2.0 is working fine on the latest release (2.0.8) - but current |
Contributor
https://discord.com/channels/613988663034118151/740631022080622745/1279118505819508857 |
diegomrsantos
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LPErroris the top level error type of libp2p, it makes more sense to raise a multi address specific subtype to avoid requiring callers to catch errors too broadly. AsMaErrorinherits fromLPError, existing error handlers will still work fine.