Refactor FT.AGGREGATE reducers to process records in batch#816
Open
AlexFilipImproving wants to merge 7 commits intovalkey-io:mainfrom
Open
Refactor FT.AGGREGATE reducers to process records in batch#816AlexFilipImproving wants to merge 7 commits intovalkey-io:mainfrom
AlexFilipImproving wants to merge 7 commits intovalkey-io:mainfrom
Conversation
fd077f8 to
cc9c9c2
Compare
Collaborator
Author
|
I also added a cleanup of the sortby_parameter added in my previous PR |
Collaborator
Author
|
I made the requested changes, but it looks like some of the compatibility tests are failing for reasons outside of this change. For example, these look like they have to do with the implementation of |
Collaborator
|
@boda26 Mind taking a look at the failing compatibility test? I was wondering if it was my recent change but this looks like a basic numeric search which should be unaffected |
Collaborator
|
Failures probably fixed by #838 |
d51f13e to
2819935
Compare
This commit squashes 59 commits containing: - Refactored FT.AGGREGATE reducers to process records in batch - Vector reducer function optimizations - Text search performance improvements - Compatibility test enhancements - Multi-DB support for FT.SEARCH - Various bug fixes and test coverage improvements - Locking optimizations for text indexes - Memory allocation improvements Key changes: - Changed ProcessRecords interface to accept all records at once for batch processing - Count reducer now O(1) instead of O(n) function calls - Improved text index locking and performance - Added comprehensive timeout coverage for search execution - Enhanced compatibility testing framework - Fixed lazy expiration crash in search commands - Optimized stemming, tokenization, and rax mutations - Added ingestion performance scenarios - Better separation between data collection and processing phases Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
2819935 to
0117d89
Compare
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
185d720 to
225c756
Compare
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the ProcessRecords interface to accept all records at once instead of processing them one at a time. This enables more efficient implementations, particularly for COUNT which now simply returns the input size rather than incrementing a counter for each record.
Changes: