fix to be able to query with both alias and identifier#836
Open
daddaman-amz wants to merge 8 commits intovalkey-io:mainfrom
Open
fix to be able to query with both alias and identifier#836daddaman-amz wants to merge 8 commits intovalkey-io:mainfrom
daddaman-amz wants to merge 8 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
daddaman-amz
commented
Mar 12, 2026
| @@ -408,7 +408,10 @@ absl::flat_hash_set<std::string> IndexSchema::GetTextIdentifiersByFieldMask( | |||
| absl::StatusOr<std::string> IndexSchema::GetIdentifier( | |||
Collaborator
Author
There was a problem hiding this comment.
Used by filter_parser.cc for numeric, tags
ParseNumericPredicate
ParseTagPredicate
daddaman-amz
commented
Mar 12, 2026
| return itr != attributes_.end() ? &itr->second : nullptr; | ||
| } | ||
|
|
||
| absl::StatusOr<vmsdk::UniqueValkeyString> IndexSchema::DefaultReplyScoreAs( |
Collaborator
Author
There was a problem hiding this comment.
Used in PreParseQueryString (search.cc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the fields has an alias and user tries to query with original identifier we throw an error.
RL behavior silently gives zero results for same case:
Ideal behavior would be to handle both cases from a query which this PR does