Backport changes to visibility based app metric review of 1.1 metrics#850
Merged
KarthikSubbarao merged 6 commits intovalkey-io:1.1from Mar 19, 2026
Merged
Conversation
Changing the following metrics
<google-sheets-html-origin><style type="text/css"><!--td {border: 1px
solid #cccccc;}br {mso-data-placement:same-cell;}--></style>
APP Metric Name | Section | Unit | APP metric Description | Release
version | Notes | Action Needed
-- | -- | -- | -- | -- | -- | --
coordinator_metadata_reconciliation_completed_count | coordinator |
Count | Count number of successful global metadata reconciliations (test
only, not meanful in production) | v1.1 |
https://github.com/valkey-io/valkey-search/pull/405This was intended for
test only | Change to Dev in v1.2 and backport to v1.1
info_fanout_fail_count | fanout | Count | Count number of failed fanout
operations | v1.1 | PR:
valkey-io#337 | Change to Dev in
v1.2 and backport to v1.1
info_fanout_retry_count | fanout | Count | Count number of retries of
fanout operation | v1.1 | PR:
valkey-io#337 | Change to Dev in
v1.2 and backport to v1.1
pause_handle_cluster_message_round_count | fanout | Count | Count number
of paused handle cluster message rounds (test only) | v1.1 |
https://github.com/valkey-io/valkey-search/pull/405This was intended for
test only | Change to Dev in v1.2 and backport to v1.1
number_of_active_indexes | index_stats | | Shows number of indexes but
should be indexes with active background indexing | v1.1 | PR:
valkey-io#314 | Needs Delete in
v1.2 and backport to v1.1Add the corrected version in future patches
number_of_active_indexes_indexing | index_stats | Bool | Current
Implementation:Boolean indicator (0 or 1) showing whether any indexes
are currently performing background indexing. Returns 1 if at least one
index is indexing, 0 if no indexes are indexing.(Name is misleading and
is not aligned with redisearch definition) | v1.1 | PR:
https://github.com/valkey-io/valkey-search/pull/314Name is misleading |
Needs Delete in v1.2 and backport to v1.1Add the corrected version in
future patches
number_of_active_indexes_running_queries | index_stats | Count | Number
of indexes currently running queries (currently returns 0 - not yet
implemented) | v1.1 | PR:
valkey-io#314 | Needs Delete in
v1.2 and backport to v1.1Add the corrected version in future patches
string_interning_memory_bytes | string_interning | Bytes | Memory used
by the string interning store (in bytes) | v1.1 | PR:
https://github.com/valkey-io/valkey-search/pull/153/changes | Change to
Dev in v1.2 and backport to v1.1
string_interning_memory_human | string_interning | String | Memory used
by the string interning store (in human-readable SI format) | v1.1 | PR:
https://github.com/valkey-io/valkey-search/pull/153/changes | Change to
Dev in v1.2 and backport to v1.1
---------
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Collaborator
Author
|
Needs couple of changes from https://github.com/valkey-io/valkey-search/pull/905/changes |
Signed-off-by: Manish Addanki <daddaman@amazon.com>
KarthikSubbarao
approved these changes
Mar 19, 2026
Member
|
I approved this PR: #850 But no tests are running on this branch. Can we fix the github yaml file to run tests on this version as well? https://github.com/valkey-io/valkey-search/blob/main/.github/workflows/integration_tests.yml The workflows are all configured to run only on main and fulltext, we can update this in your PR Just need to include 1.1 as the branch in the files in the workflows folder |
Signed-off-by: Manish Addanki <daddaman@amazon.com>
Signed-off-by: Manish Addanki <daddaman@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main PR: #754