Support testing against external Valkey servers#908
Open
Nikhil-Manglore wants to merge 10 commits intovalkey-io:mainfrom
Open
Support testing against external Valkey servers#908Nikhil-Manglore wants to merge 10 commits intovalkey-io:mainfrom
Nikhil-Manglore wants to merge 10 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
…lore/valkey-search into external_search_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for running integration tests against an external Valkey server instance, controlled by the
VALKEY_EXTERNAL_SERVERenvironment variable.This will primarily be used in the Valkey Bundle to run a subset of tests against the valkey-bundle Docker image, ensuring core search functionality works as expected. This approach is used for all modules in the bundle.