fix: sass-embedded@1.98.0 在 macOS 13 会直接崩 by pzzyf · Pull Request #7692 · vbenjs/vue-vben-admin

pzzyf · 2026-03-18T08:03:46Z

sass-embedded@1.98.0 在 macOS 13 会直接崩

Summary by CodeRabbit

Documentation
- Updated configuration file references from TypeScript (.ts) to ES modules (.mjs) format in project guides.
Style
- Standardized quote formatting across configuration modules.
- Applied JSON formatting adjustments including trailing commas in workspace configuration.

changeset-bot · 2026-03-18T08:03:56Z

⚠️ No Changeset found

Latest commit: 3c4647d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-18T08:04:13Z

📝 Walkthrough

Walkthrough

The PR updates configuration file references from TypeScript (.ts) to ES Module (.mjs) extensions across documentation, normalizes import statement quote styles in the Vite configuration, and adds trailing commas to JSON elements in the workspace configuration file. All changes are documentation and formatting updates with no functional behavior modifications.

Changes

Cohort / File(s)	Summary
Documentation Config References `docs/src/en/guide/project/dir.md`, `docs/src/en/guide/project/standard.md`, `docs/src/guide/project/dir.md`, `docs/src/guide/project/standard.md`	Updated configuration file extension references from `oxfmt.config.ts` → `oxfmt.config.mjs` and `oxlint.config.ts` → `oxlint.config.mjs` across English and main guide documentation.
Import Path Normalization `internal/vite-config/src/config/application.ts`	Converted single-quoted module specifiers to double quotes (e.g., `'vite'` → `"vite"`, `'sass-embedded'` → `"sass"`), adjusted NodePackageImporter import source, and reformatted mergeConfig call to single line.
JSON Formatting `vben-admin.code-workspace`	Added trailing commas to JSON string values and array elements throughout the workspace configuration file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

fix: global scss injection error problem #4014: Modifies internal/vite-config/src/config/application.ts with Sass-related import/handling changes.
fix: oxlint config #7661: Updates oxlint configuration entry references and documentation.

Suggested labels

bug

Suggested reviewers

anncwb
vince292007
mynetfan
jinmao88

Poem

🐰 Hops of joy for cleaner code,
From .ts to .mjs we now rode,
Quotes align in double grace,
Trailing commas find their place!
Config files dressed up neat,
Documentation now complete!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references a specific dependency issue (sass-embedded@1.98.0 crashing on macOS 13), but changes focus on configuration file extensions and import formatting, making the title misleading.	Revise title to accurately reflect the actual changes: updating config file extensions from .ts to .mjs and adjusting import quote styles, not just addressing a sass-embedded crash.
Description check	⚠️ Warning	The PR description is entirely incomplete, containing only the title repeated without addressing the template structure, change rationale, type of change, or any checklist items.	Fill out the complete description template including a detailed explanation of why .mjs files fix the sass-embedded issue, the type of change, and completed checklist items.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

coderabbitai

🧹 Nitpick comments (1)

internal/vite-config/src/config/application.ts (1)
1-16: Remove unused sass-embedded from devDependencies.

The sass-embedded package is declared in internal/vite-config/package.json but is not used anywhere in the codebase. The code imports from sass instead. Removing this unused dependency will reduce clutter and avoid confusion.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@internal/vite-config/src/config/application.ts` around lines 1 - 16, The
devDependency "sass-embedded" is unused—your code imports from "sass" (and uses
NodePackageImporter) so remove "sass-embedded" from internal/vite-config's
package.json devDependencies, run a quick grep for "sass-embedded" to ensure
nothing else references it, and update lockfile (run npm/yarn/pnpm install) so
the dependency is fully removed from the repo and CI.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@internal/vite-config/src/config/application.ts`:
- Around line 1-16: The devDependency "sass-embedded" is unused—your code
imports from "sass" (and uses NodePackageImporter) so remove "sass-embedded"
from internal/vite-config's package.json devDependencies, run a quick grep for
"sass-embedded" to ensure nothing else references it, and update lockfile (run
npm/yarn/pnpm install) so the dependency is fully removed from the repo and CI.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f2fbce9a-bfd2-4674-b329-220a39ed3c11

📥 Commits

Reviewing files that changed from the base of the PR and between 885a0a9 and 3c4647d.

📒 Files selected for processing (8)

docs/src/en/guide/project/dir.md
docs/src/en/guide/project/standard.md
docs/src/guide/project/dir.md
docs/src/guide/project/standard.md
internal/vite-config/src/config/application.ts
oxfmt.config.mjs
oxlint.config.mjs
vben-admin.code-workspace

doraemonxxx · 2026-03-18T10:59:17Z

What? I thought formatter uses single quote instead of double qoute

xingyu4j · 2026-03-18T12:26:23Z

所有的页面单双引号全部报错了

https://github.com/vbenjs/vue-vben-admin/actions/runs/23244373299/job/67568761875?pr=7693

This reverts commit b908076.

wu-clan · 2026-03-18T12:45:01Z

这个 PR 和标题似乎没有什么关系？更可能与 node 版本有关？#7663

This reverts commit b908076.

pzzyf · 2026-03-18T12:49:03Z

What? I thought formatter uses single quote instead of double qoute

sry，I submitted a rollback.

pzzyf · 2026-03-18T12:51:29Z

这个 PR 和标题似乎没有什么关系？更可能与 node 版本有关？#7663

pzzyf · 2026-03-18T12:52:28Z

所有的页面单双引号全部报错了

https://github.com/vbenjs/vue-vben-admin/actions/runs/23244373299/job/67568761875?pr=7693

sry，I submitted a rollback.

wu-clan · 2026-03-18T13:02:25Z

这个 PR 和标题似乎没有什么关系？更可能与 node 版本有关？#7663

.ts -> .mjs、引号和 sass-embedded 并无关，AI 似乎存在误导

核心代码变更只是：import { NodePackageImporter } from 'sass-embedded';

另外，macOS 13 (Ventura) 已停止维护，多个软件都已不再适配，我想最具代表性的是 Homebrew.

pzzyf · 2026-03-18T13:15:14Z

这个 PR 和标题似乎没有什么关系？更可能与 node 版本有关？#7663

.ts -> .mjs、引号和 sass-embedded 并无关，AI 似乎存在误导

核心代码变更只是：import { NodePackageImporter } from 'sass-embedded';

另外，macOS 13 (Ventura) 已停止维护，多个软件都已不再适配，我想最具代表性的是 Homebrew.

.ts -> .mjs、引号和 sass-embedded 并无关，AI 似乎存在误导是因为提交代码出发hook，提交不上去，codex给oxlint改了，已经pr一个回退pr了。

doraemonxxx · 2026-03-18T13:59:24Z

Why it is merged? This should be reverted?

Edit
Ohh. You submitted another PR to revert. Thanks

pzzyf · 2026-03-18T14:24:52Z

Why it is merged? This should be reverted?

The merge was made because Premiere Pro did indeed resolve the conflict between Sass and macOS 13. The rollback was due to the formatting issue it caused, and I had already upgraded my macOS to version 15 or later.

Lmx1220 · 2026-03-18T23:32:13Z

为什么要合并？应该撤销合并吗？

合并操作之所以进行，是因为 Premiere Pro 确实解决了 Sass 和 macOS 13 之间的冲突。回滚操作是由于它导致的格式问题，而我已经将 macOS 升级到了 15 或更高版本。

sass-embedded不兼容mac14以下版本，sass-embedded前一个版本支持。sass-embedded另外一个编译语言执行编译css样式会比sass用node编译更快

pzzyf added 2 commits March 18, 2026 15:52

fix: catelog

4e6847d

fix: system

3c4647d

pzzyf requested review from a team, anncwb, jinmao88, mynetfan and vince292007 as code owners March 18, 2026 08:03

coderabbitai bot reviewed Mar 18, 2026

View reviewed changes

jinmao88 merged commit b908076 into vbenjs:main Mar 18, 2026
12 of 14 checks passed

pzzyf added a commit to pzzyf/vue-vben-admin that referenced this pull request Mar 18, 2026

Revert "fix: sass-embedded@1.98.0 在 macOS 13 会直接崩 (vbenjs#7692)"

1f8c3e8

This reverts commit b908076.

pzzyf added a commit to pzzyf/vue-vben-admin that referenced this pull request Mar 18, 2026

Revert "fix: sass-embedded@1.98.0 在 macOS 13 会直接崩 (vbenjs#7692)"

b467f6a

This reverts commit b908076.

coderabbitai bot mentioned this pull request Mar 18, 2026

Revert "fix: sass-embedded@1.98.0 在 macOS 13 会直接崩 (#7692)" #7694

Closed

jinmao88 added a commit that referenced this pull request Mar 19, 2026

revert: "fix: sass-embedded@1.98.0 在 macOS 13 会直接崩 (#7692)"

bed97a8

Conversation

pzzyf commented Mar 18, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 18, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (2 warnings)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

doraemonxxx commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

xingyu4j commented Mar 18, 2026

Uh oh!

wu-clan commented Mar 18, 2026

Uh oh!

pzzyf commented Mar 18, 2026

Uh oh!

pzzyf commented Mar 18, 2026

Uh oh!

pzzyf commented Mar 18, 2026

Uh oh!

wu-clan commented Mar 18, 2026

Uh oh!

pzzyf commented Mar 18, 2026

Uh oh!

doraemonxxx commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pzzyf commented Mar 18, 2026

Uh oh!

Lmx1220 commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pzzyf commented Mar 18, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 18, 2026 •

edited

Loading

doraemonxxx commented Mar 18, 2026 •

edited

Loading

doraemonxxx commented Mar 18, 2026 •

edited

Loading