feat(codecs): add support for decimal type#25048
Open
benjamin-awd wants to merge 1 commit intovectordotdev:masterfrom
Open
feat(codecs): add support for decimal type#25048benjamin-awd wants to merge 1 commit intovectordotdev:masterfrom
benjamin-awd wants to merge 1 commit intovectordotdev:masterfrom
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for a new
decimaltype backed by therust_decimalcrate. Sibling VRL PR: vectordotdev/vrl#1719 (issue: vectordotdev/vrl#1692).Note: this requires the VRL PR to be merged first.
This feature should be considered in beta, some additional work will have to be done in the future to wire up existing sinks to work with the decimal type.
Benchmark results:
Single-event results
Batch results
Vector configuration
How did you test this PR?
Tests in VRL and Vector
Change Type
Is this a breaking change?
This shouldn't have any breaking changes unless decimal parsing is enabled.
Does this PR include user facing changes?
no-changeloglabel to this PR.