Skip to content

Conversation

@MangioneAndrea
Copy link

@MangioneAndrea MangioneAndrea commented Dec 9, 2025

374 - Custom keyboard bindings

Fixes # 374

Description

Add customizable keyboard binding from file settings

List here your changes

  • Added a key bindings client
  • Replaced all hardcoded keybindings through customizable ones
  • Set previous key bindings as default

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have introduced no new C-bindings
  • The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: ...

@cocogitto-bot
Copy link

cocogitto-bot bot commented Dec 9, 2025

✔️ b0743ec...53b6f7c - Conventional commits check succeeded.

Event::Keyboard(KeyEvent { code: Key::Esc, .. }) => {
Some(Msg::Ui(UiMsg::CloseSaveBookmark))
}
// Event::Keyboard(KeyEvent { code: Key::Esc, .. }) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it commented?

self.perform(Cmd::Change);
Some(Msg::None)
}
// Event::Keyboard(KeyEvent { code: Key::Tab, .. }) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all these commented?

@veeso veeso linked an issue Jan 3, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] - Customisable key bindings

2 participants