fix: keep params in path overlay normalizer at the higher level#9258
Draft
fix: keep params in path overlay normalizer at the higher level#9258
Conversation
Contributor
Member
Author
|
The ci should have taken care of examples that are in the repo already. The question is whether the params should be in the first layer rather than at the outer spec level. The code looked intentional so I wanted to have someone else check. |
Member
Author
|
I think a good check is whether a deeply nested spec breaks with this change. And test selection params. I should do those. |
Contributor
|
The intention of this PR is not exactly clear, but is the following issue + comment related here? #8230 (comment) Also, when is this code invoked? I think this param lifting could be done in the section creating the extended vega-lite code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Previously we moved the params into the layer but it seems like we should keep it at the higher level.
This fixes an issue that surfaced in #9253.