Skip to content

feat(core): Provide app instance before app starts listening#4383

Merged
michaelbromley merged 5 commits intovendurehq:minorfrom
LucidityDesign:feat/api-interceptor
Mar 5, 2026
Merged

feat(core): Provide app instance before app starts listening#4383
michaelbromley merged 5 commits intovendurehq:minorfrom
LucidityDesign:feat/api-interceptor

Conversation

@LucidityDesign
Copy link

@LucidityDesign LucidityDesign commented Feb 20, 2026

Description

I'm trying to set up swagger/openAPI.

Bootstrapping swagger requires the instance to app before app.listen has been called (see https://docs.nestjs.com/openapi/introduction#bootstrap). So currently I can't find an easy way to set up swagger for my REST endpoints in Vendure.

@michaelbromley What do you think about this solution? If you like it I can add documentation and finish this PR.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vendure-storybook Ready Ready Preview, Comment Mar 5, 2026 4:13pm

Request Review

Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
This is a good idea and needed.

I think a better place for this would be in the BootstrapOptions object. It's not really part of the VendureConfig, conceptually.

Also mark it as @since 3.6.0 because it would be released with that version.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 137d0a96-b1d0-41fe-b894-50fdc233580d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there now - I'd just like a different example given in the docs to avoid confusion.

@michaelbromley michaelbromley enabled auto-merge (squash) March 5, 2026 16:14
@michaelbromley michaelbromley merged commit 2b5a887 into vendurehq:minor Mar 5, 2026
18 of 19 checks passed
@LucidityDesign LucidityDesign deleted the feat/api-interceptor branch March 5, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants