feat(core): Provide app instance before app starts listening#4383
feat(core): Provide app instance before app starts listening#4383michaelbromley merged 5 commits intovendurehq:minorfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
michaelbromley
left a comment
There was a problem hiding this comment.
Hi!
This is a good idea and needed.
I think a better place for this would be in the BootstrapOptions object. It's not really part of the VendureConfig, conceptually.
Also mark it as @since 3.6.0 because it would be released with that version.
d961864 to
f41669f
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f41669f to
34c76ed
Compare
michaelbromley
left a comment
There was a problem hiding this comment.
Almost there now - I'd just like a different example given in the docs to avoid confusion.
9ede573 to
68867fc
Compare
68867fc to
27e94df
Compare
Description
I'm trying to set up swagger/openAPI.
Bootstrapping swagger requires the instance to app before
app.listenhas been called (see https://docs.nestjs.com/openapi/introduction#bootstrap). So currently I can't find an easy way to set up swagger for my REST endpoints in Vendure.@michaelbromley What do you think about this solution? If you like it I can add documentation and finish this PR.
Breaking changes
Does this PR include any breaking changes we should be aware of?
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: