fix(core,dashboard): make coupon code validation case-insensitive#4438
Open
Jeffrey-manzl wants to merge 1 commit intomajorfrom
Open
fix(core,dashboard): make coupon code validation case-insensitive#4438Jeffrey-manzl wants to merge 1 commit intomajorfrom
Jeffrey-manzl wants to merge 1 commit intomajorfrom
Conversation
Coupon codes are now validated case-insensitively across the backend. The Dashboard also auto-uppercases coupon codes on input for consistency. Closes OSS-371
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coupon codes are now validated case-insensitively across the entire backend. Previously, a customer entering
abc10when the coupon code wasABC10would get an "invalid coupon" error. This aligns Vendure with the behavior of other major e-commerce platforms (Shopify, WooCommerce).Additionally, the Dashboard now auto-uppercases coupon code input for consistency.
Closes OSS-371
Changes:
promotion.service.ts: UseLOWER()in DB query for case-insensitive coupon lookuppromotion.entity.ts: Case-insensitive comparison intest()methodorder.service.ts: Case-insensitiveapplyCouponCodeandremoveCouponCodeorder-modifier.ts: Case-insensitive coupon code checks in order modificationpromotions_.$id.tsx: Auto-uppercase coupon code input in Dashboardorder-promotion.e2e-spec.ts: Updated test to verify case-insensitive behaviorBreaking changes
No breaking changes. Coupon codes that previously required exact case matching will now match case-insensitively.
Screenshots
Checklist
📌 Always:
👍 Most of the time: