fix: avoid paragraph wrappers for loose list items#476
Open
saschabuehrle wants to merge 1 commit intovercel:mainfrom
Open
fix: avoid paragraph wrappers for loose list items#476saschabuehrle wants to merge 1 commit intovercel:mainfrom
saschabuehrle wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@saschabuehrle is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const normalizedChildren = | ||
| childArray.length === 1 && | ||
| isValidElement(childArray[0]) && | ||
| childArray[0].type === "p" |
Contributor
There was a problem hiding this comment.
Suggested change
| childArray[0].type === "p" | |
| childArray[0].type === MemoParagraph |
The check childArray[0].type === "p" in MemoLi never matches because hast-util-to-jsx-runtime maps p elements to the MemoParagraph component, making .type the component function rather than the string "p".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475
Loose list items can come through as a single
<p>child when models insert blank lines between bullets. This unwraps that single paragraph case in thelirenderer so output stays consistent, and adds a regression test for the reported markdown.Greetings, saschabuehrle