fix: allow null fetcher to override global SWRConfig fetcher#4238
Open
Gdhanush-13 wants to merge 1 commit intovercel:mainfrom
Open
fix: allow null fetcher to override global SWRConfig fetcher#4238Gdhanush-13 wants to merge 1 commit intovercel:mainfrom
Gdhanush-13 wants to merge 1 commit intovercel:mainfrom
Conversation
When fn is explicitly null, the || operator falls through to config.fetcher. Use !== undefined check so null is respected as an intentional override. Fixes vercel#2888
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2888
useSWR('key', null)with a globalSWRConfigfetcher still fires a request becausefn || config.fetchertreatsnullas falsy.Changed to
fn !== undefined ? fn : config.fetcher || nullso explicitly passingnullis respected as an intentional override.