Windows commands: Fix command execution output, exit codes, and verbose mode handling#72
Open
Artemeey wants to merge 31 commits into
Open
Windows commands: Fix command execution output, exit codes, and verbose mode handling#72Artemeey wants to merge 31 commits into
Artemeey wants to merge 31 commits into
Conversation
…ting fix: Windows PHP install quoting
fix: os.execute(installCmd)
Signed-off-by: Artemeey <artemeey.ru@mail.ru>
fix: os.execute(installCmd)
… into fix-windows-php-install-quoting
Fix windows php install quoting
fix: use target PHP path for PIE extensions
This reverts commit 791ab19.
This reverts commit 791ab19.
# Conflicts: # bin/install-windows-php.ps1 # hooks/post_install.lua # lib/tools.lua
# Conflicts: # hooks/post_install.lua # lib/tools.lua
- Fixed returning the correct command exit code - Fixed command output handling - Added support for paths and arguments containing spaces - Added cmd command output in verbose mode - Added streaming command output in verbose mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade execute_cmd:
Also fixed set env VERBOSE
Tested on: