Allow requiring installed libhandlegraph, and stop adding aliases libhandlegraph adds already that don't work with the installed version #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handlegraph adds already that don't work with the installed version
Member
Author
|
This might be related to or partly supersede #81. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out in the vg build we've been using the libvgio-bundled libhandlegraph and not the vg submodule version. But when you pass the CMake flag to use the vg-installed version, the alias commands fail due to not having the non-namespaced targets around.
The alias commands have been in libhandlegraph itself for a while, so we don't need them here.