Merged
Conversation
🦋 Changeset detectedLatest commit: e8e19e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mattmacf98
approved these changes
Feb 13, 2026
| // WithColors creates a configuration option that sets colors for any type implementing ConfigurableColors. | ||
| func WithColors[T ConfigurableColors](colors []Color) func(T) { | ||
| // withColors creates a configuration option that sets colors for any type implementing ConfigurableColors. | ||
| func withColors[T ConfigurableColors](colors []Color) func(T) { |
Collaborator
Author
There was a problem hiding this comment.
It's generic, so it's not very useful to external users. Technically, I guess it could be useful if folks wanted to add their own custom color options for shapes. But I didn't want it confusing folks using the draw API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withColorsgeneric function private, it's not useful externallyWithRGBAlogic toWithColorRGBAto reflect that it is aColor.RGBAstruct helperWithRGBAhelper that just accepts RGBA valuesWithHexhelper that accepts color hex stringsColorFrom*helpers to make it easier to generate a new color with simple requirements