fix(big-play-button): component customization#8398
Open
amtins wants to merge 1 commit intovideojs:mainfrom
Open
fix(big-play-button): component customization#8398amtins wants to merge 1 commit intovideojs:mainfrom
amtins wants to merge 1 commit intovideojs:mainfrom
Conversation
Allows to easily change the visual aspect of the component without having to adjust the positioning. - remove `margin` top/left used to center the component - add `translate` x/y to center the component regardless of its size - remove the `line-height` used to center the play `icon` - add display `flex` to center of pseudo-elements - keep `height` at 100% to fill the parent as before
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8398 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 113 113
Lines 7578 7578
Branches 1821 1821
=======================================
Hits 6266 6266
Misses 1312 1312 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This is better approach, but there's potential to break users' existing customisations based on the styles as they are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows to easily change the visual aspect of the component without having to adjust the positioning.
Screencast.from.12.08.23.20.37.48.webm
Reduced test case
Specific Changes proposed
margintop/left used to center the componenttranslatex/y to center the component regardless of its sizeline-heightused to center the playiconflexto center of pseudo-elementsheightat 100% to fill the parent as beforeRequirements Checklist