Skip to content

[Fix] Increase SSH timeout for install jobs + dpkg config#1169

Merged
saeedvaziry merged 3 commits into
vitodeploy:4.xfrom
RichardAnderson:fix/dpkg
Jun 18, 2026
Merged

[Fix] Increase SSH timeout for install jobs + dpkg config#1169
saeedvaziry merged 3 commits into
vitodeploy:4.xfrom
RichardAnderson:fix/dpkg

Conversation

@RichardAnderson

@RichardAnderson RichardAnderson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Improvements
    • Enhanced SSH queue connection with extended timeout values (600s → 1200s) and adjusted retry configuration.
    • Improved OS-level package installation and upgrade processes with non-interactive mode and better handling of system configuration files during updates.
    • Updated SSH supervisor defaults for optimised connection management.

@RichardAnderson
RichardAnderson requested a review from Copilot June 17, 2026 23:15
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ab1e67b6-36f7-4550-bd01-338a7832e617

📥 Commits

Reviewing files that changed from the base of the PR and between fff30ec and 39bbf67.

📒 Files selected for processing (5)
  • config/horizon.php
  • config/queue.php
  • resources/views/ssh/os/install-dependencies.blade.php
  • resources/views/ssh/os/upgrade-kernel.blade.php
  • resources/views/ssh/os/upgrade.blade.php

📝 Walkthrough

Walkthrough

Two sets of configuration and script changes: SSH queue timeouts are doubled to 1200 seconds (retry_after to 1260), the Horizon ssh supervisor connection is corrected from 'redis' to 'ssh', and the ssh queue name is changed from 'default' to 'ssh'. Three OS apt-get scripts gain non-interactive dpkg flags (--force-confdef, --force-confold, NEEDRESTART_MODE=a).

Changes

SSH Operation Reliability

Layer / File(s) Summary
SSH queue and Horizon worker timeout and connection fixes
config/horizon.php, config/queue.php
config/horizon.php changes the ssh supervisor connection from 'redis' to 'ssh' and raises the timeout fallback from 600 to 1200 seconds. config/queue.php renames the ssh queue from 'default' to 'ssh', increases timeout to 1200, and increases retry_after to 1260.
Non-interactive dpkg flags for apt-get commands
resources/views/ssh/os/install-dependencies.blade.php, resources/views/ssh/os/upgrade.blade.php, resources/views/ssh/os/upgrade-kernel.blade.php
install-dependencies.blade.php adds DEBIAN_FRONTEND=noninteractive, NEEDRESTART_MODE=a, and Dpkg::Options::="--force-confdef" / --force-confold to both the initial apt-get install and the mise repository update/install commands. upgrade.blade.php and upgrade-kernel.blade.php add the same Dpkg::Options flags to apt-get upgrade and apt-get dist-upgrade respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two primary changes: increasing SSH timeout values and adding dpkg configuration flags to apt commands.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make SSH-based OS/package installation steps more reliably non-interactive (avoiding dpkg conffile prompts) and to allow longer-running SSH install jobs by increasing queue worker timeouts.

Changes:

  • Add dpkg conffile options (--force-confdef/--force-confold) to unattended apt-get upgrade and dependency installation.
  • Increase SSH queue worker timeouts (Queue + Horizon) to 1200s.
  • Adjust retry_after for the SSH queue connection to exceed the new timeout.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
resources/views/ssh/os/upgrade.blade.php Adds dpkg conffile options to reduce interactive upgrade prompts.
resources/views/ssh/os/install-dependencies.blade.php Makes initial dependency install non-interactive and attempts to avoid dpkg conffile prompts.
config/queue.php Increases SSH connection timeout/retry window intended for long-running SSH jobs.
config/horizon.php Increases Horizon ssh supervisor timeout to allow longer SSH jobs.

Comment thread config/horizon.php
Comment thread resources/views/ssh/os/install-dependencies.blade.php Outdated
Comment thread resources/views/ssh/os/install-dependencies.blade.php Outdated
Comment thread resources/views/ssh/os/upgrade.blade.php Outdated
Comment thread resources/views/ssh/os/upgrade.blade.php Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread config/queue.php
Comment thread resources/views/ssh/os/install-dependencies.blade.php
@RichardAnderson
RichardAnderson marked this pull request as ready for review June 18, 2026 00:50
@saeedvaziry
saeedvaziry merged commit fa6d1a0 into vitodeploy:4.x Jun 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants