[Fix] Increase SSH timeout for install jobs + dpkg config#1169
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughTwo sets of configuration and script changes: SSH queue timeouts are doubled to 1200 seconds ( ChangesSSH Operation Reliability
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR aims to make SSH-based OS/package installation steps more reliably non-interactive (avoiding dpkg conffile prompts) and to allow longer-running SSH install jobs by increasing queue worker timeouts.
Changes:
- Add dpkg conffile options (
--force-confdef/--force-confold) to unattendedapt-get upgradeand dependency installation. - Increase SSH queue worker timeouts (Queue + Horizon) to 1200s.
- Adjust
retry_afterfor the SSH queue connection to exceed the new timeout.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| resources/views/ssh/os/upgrade.blade.php | Adds dpkg conffile options to reduce interactive upgrade prompts. |
| resources/views/ssh/os/install-dependencies.blade.php | Makes initial dependency install non-interactive and attempts to avoid dpkg conffile prompts. |
| config/queue.php | Increases SSH connection timeout/retry window intended for long-running SSH jobs. |
| config/horizon.php | Increases Horizon ssh supervisor timeout to allow longer SSH jobs. |
Summary by CodeRabbit