Skip to content

Conversation

@ar-jan
Copy link
Contributor

@ar-jan ar-jan commented Jan 13, 2026

Testing the changes

  • I tested the changes in this PR: briefly (podman) / NO (skopeo)

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

This switches containers-common, containers.image, and containers.storage to the container-libs monorepo.

Updated skopeo to match podman 5.7, but I don't use it, not tested.

@ar-jan
Copy link
Contributor Author

ar-jan commented Jan 13, 2026

The skopeo check was already failing with the previous version (locally). Suggestions?

@ahesford
Copy link
Member

Given that these several of these packages now exist in the same tree, they should probably be built together and broken out into subpackages after the fact. Renaming containers-common to containers.common might be nice as well, to bring consistency with the other subpackages.

@ar-jan
Copy link
Contributor Author

ar-jan commented Jan 13, 2026

The three subpackages do have different versions released separately at different times. Is it still desirable to combine them in one template? And what should that look like?

@ahesford
Copy link
Member

No, I suppose it's not desirable to combine these. I looked past the different versions and only saw the common repository. This accumulation makes no sense, but I guess we're stuck it it.

@ar-jan
Copy link
Contributor Author

ar-jan commented Jan 13, 2026

I tried some things around the test errors with PATH, but not sure what is needed there.

do_check() {
    export PATH="${PWD}/_build-skopeo-xbps/bin:${PATH}"
    go test -p "$XBPS_MAKEJOBS" -tags "${go_build_tags}" ./...
}

This seems to fix the exec: "skopeo": executable file not found in $PATH error seen in CI, but then results in

github.com/containers/skopeo/cmd/skopeo/inspect [no test files]
--- FAIL: TestSkopeo (0.00s)
....
exec: "registry": executable file not found in $PATH`.

Since the skopeo tests are already failing with current version, OK to just skip them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants