Skip to content

Conversation

@gc-user
Copy link
Contributor

@gc-user gc-user commented Jan 15, 2026

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

Note: The package builds, installs and runs fine with the template as proposed, but the readme states the following:

"Build options and their dependencies

This is the list of configurable packages and what they provide in nomacs. To ensure a feature is included/excluded set the cmake option for that feature. By default, all features are enabled if the dependencies are found when running cmake**.

The following Qt components are necessary: Core, Concurrent, Network, PrintSupport, SVG, Widgets, Core5Compat."

Of these dependencies only qt6-svg-devel was already present from previous versions. I added qt6-qt5compat-devel because the build would otherwise fail.

The packages qt6-core qt6-concurrent qt6-network qt6-printsupport qt6-widgets aren't necessary for building without error messages.
But as they are explicitly mentioned, I wonder if I should still add them. I wouldn't know, though, where to add them - to makedepends, hostmakedepends or even depends?

Another question would be the added -DENABLE_QUAZIP=1.
I did a build test with the previous version and during checks it said that quazip was enabled. Without any changes to the template in that regard for the new version, it would say that quazip was not included. So, I added the argument. I also did a test install with both options. With the added argument, the install would also install quazip-qt6, without the argument, it would not. I'm not sure if nomacs would be able to use the qt5 version of quazip that the previous version depended on. The qt5compat dependency might allow for that - or not, I don't know. So, the question would be if the added argument is needed or if it would be incompatible with the pre-existing argument -DUSE_SYSTEM_QUAZIP=1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant