fix(cli): override rolldown panic hook with vite-plus branding#1287
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(cli): override rolldown panic hook with vite-plus branding#1287graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
commented
Apr 3, 2026
branchseer
reviewed
Apr 3, 2026
branchseer
approved these changes
Apr 3, 2026
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
Since rolldown_binding is bundled into the same NAPI binary, its module_init panic hook catches all panics and misleadingly shows "Rolldown panicked" with a link to rolldown's issue tracker. Replace it at the start of run() with a vite-plus specific hook that correctly attributes panics and links to the vite-plus bug report. Closes #1285
graphite-app
bot
force-pushed
the
fix-panicked-1285
branch
from
09b6e25 to
dde546f
Compare
Since rolldown_binding is bundled into the same NAPI binary, its module_init panic hook catches all panics and misleadingly shows "Rolldown panicked" with a link to rolldown's issue tracker. Replace it at the start of run() with a vite-plus specific hook that correctly attributes panics and links to the vite-plus bug report. Closes #1285
graphite-app
bot
force-pushed
the
fix-panicked-1285
branch
from
dde546f to
5ac585a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rolldown_binding is bundled into the same NAPI binary, its
module_init panic hook catches all panics and misleadingly shows
"Rolldown panicked" with a link to rolldown's issue tracker.
Replace it at the start of run() with a vite-plus specific hook that
correctly attributes panics and links to the vite-plus bug report.
Closes #1285