fix(cli): enable cache support for vp check in task runner#1328
Draft
fix(cli): enable cache support for vp check in task runner#1328
vp check in task runner#1328Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
vp-check-support-cache
branch
4 times, most recently
from
272b3c3 to
2bb54c0
Compare
When `vp check` was used as a script (e.g., `"check": "vp check"`) and
run via `vp run check` with `run: { cache: true }`, cache was always
disabled because the command handler forced `UserCacheConfig::disabled()`.
Change the Check handler to use `UserCacheConfig::with_config(...)` with
auto input tracking and task-cache directory exclusions, matching the
pattern used by other synthesized commands (build, lint, fmt).
fengmk2
force-pushed
the
vp-check-support-cache
branch
from
2bb54c0 to
d08d260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
vp checkwas used as a script (e.g.,"check": "vp check") andrun via
vp run checkwithrun: { cache: true }, cache was alwaysdisabled because the command handler forced
UserCacheConfig::disabled().Change the Check handler to use
UserCacheConfig::with_config(...)withauto input tracking and task-cache directory exclusions, matching the
pattern used by other synthesized commands (build, lint, fmt).