feat: special purpose pages content collection by jurgenbelien · Pull Request #294 · voorhoede/head-start

jurgenbelien · 2025-07-20T20:28:58Z

Changes

Lets ESLint allow rest operator for removing properties from objects.
Another update to error reporting
Pass noIndex to Pages Content Collection entries
Add purpose field to Pages Content Collection entries
Migrates HomePage and NotFoundPage singletons to regular Pages
- These pages are set in Website (app) settings
- Two separate migrations, one for schema, one for content make this easier
Download said settings to site.json
Creates a SpecialPages Contentent Collection for 404, home, and others pages to come
Drops the Home route, now handled by pages/[locale][...path]/index.astro

Associated issue

Resolves #291

How to test

Checklist

I have performed a self-review of my own code
I have made sure that my PR is easy to review (not too big, includes comments)
I have made updated relevant documentation files (in project README, docs/, etc)
I have added a decision log entry if the change affects the architecture or changes a significant technology
I have notified a reviewer

jurgenbelien · 2025-07-20T20:30:39Z

+      '@typescript-eslint/no-unused-vars': ['error', { 
+        argsIgnorePattern: '^_', 
+        destructuredArrayIgnorePattern: '^_',        
+        ignoreRestSiblings: true,


This makes omitting propeties from objects in Typescript a whole lot easier.

jurgenbelien · 2025-07-20T20:31:25Z

+      return rest;
+    });
+
+  const content = JSON.stringify(renameKeys({ ...site, app }), null, 2);


I'm not completely sure about this, but I felt I needed it to make sure that the getHref function still works for the homepage.

Another option would be a content collection that would map record Ids to their respective paths, but that would turn the getHref function asynchronous.

I actually think it's nice to have some way to statically determine what the special purpose pages are.
I think this is the most efficient way to select it from a collection, to have the IDs known beforehand and eventually select from a collection based on the ID.

cloudflare-workers-and-pages · 2025-07-20T20:41:27Z

Deploying head-start with Cloudflare Pages

Latest commit:	`7c65408`
Status:	✅ Deploy successful!
Preview URL:	https://30989126.head-start.pages.dev
Branch Preview URL:	https://feat-special-pages.head-start.pages.dev

View logs

MarleenEliza

Looks good!

But I have some concerns:

The slug of a page cannot be left empty. Isn't this desirable for the Home Page though? The language buttons in the top right corner still reflect the link with the set slug.

If the specialized pages are unset, the website cannot be built. I know this is by design, but this might be worth mentioning in the docs?

jurgenbelien · 2025-07-22T11:42:19Z

Looks good!

But I have some concerns:

The slug of a page cannot be left empty. Isn't this desirable for the Home Page though? The language buttons in the top right corner still reflect the link with the set slug.

I resolved the issue with the language toggle, and added a test scenario for it. The slug field now has an help text explaining that for home it is ignored.

If the specialized pages are unset, the website cannot be built. I know this is by design, but this might be worth mentioning in the docs?

I've added it to getting-started.md

jurgenbelien · 2025-07-22T12:46:44Z

+  for (const record of recordsReferencingHomePage) {
+    const { id, type, item_type, meta, creator, ...content } = record;
+    const title = isLocalizedField(content.title)
+      ? content.title[locales[0]]
+      : content.title;
+    console.log(`Updating record "${title || id}"`);
+    await client.items.update(
+      record.id,
+      replaceReferences(content, homePageModel.singleton_item.id, home_page),
+    );
+  }


this migrates any record that has a reference to the old home page to the new home page

jurgenbelien · 2025-07-22T12:47:14Z

+  for (const record of recordsReferencingNotFoundPage) {
+    const { id, type, item_type, meta, creator, ...content } = record;
+    const title = isLocalizedField(content.title)
+      ? content.title[locales[0]]
+      : content.title;
+    console.log(`Updating record "${title || id}"`);
+    await client.items.update(
+      record.id,
+      replaceReferences(content, notFoundPageModel.singleton_item.id, not_found_page),
+    );
+  }


same for the not found pages, although the chance of that being necessary is slim

jurgenbelien commented Jul 20, 2025

View reviewed changes

jurgenbelien force-pushed the feat/special-pages branch from ecf76d7 to 3d538b2 Compare July 20, 2025 20:40

jurgenbelien force-pushed the feat/special-pages branch from 3d538b2 to 8c96afc Compare July 20, 2025 20:43

jurgenbelien marked this pull request as ready for review July 20, 2025 20:47

jurgenbelien requested a review from jbmoelker July 20, 2025 20:47

MarleenEliza reviewed Jul 21, 2025

View reviewed changes

jurgenbelien force-pushed the feat/special-pages branch 5 times, most recently from 72e8c4c to 7bc4476 Compare July 22, 2025 11:41

jurgenbelien force-pushed the feat/special-pages branch from 7bc4476 to da4842d Compare July 22, 2025 12:45

jurgenbelien commented Jul 22, 2025

View reviewed changes

jurgenbelien marked this pull request as draft September 8, 2025 06:27

jurgenbelien added 5 commits September 9, 2025 12:02

chore(eslint): allow using rest for removing properties from objects

03ed225

feat(datocms): better error reporting by showing query variables

16508f6

style(content): write loadEntry and loadCollection as regular functions

6796082

feat(content): add noIndex field to page meta

b7689b3

docs: remove references to Home Page model

80c85ff

jurgenbelien force-pushed the feat/special-pages branch 2 times, most recently from ca92d33 to 9d0ced6 Compare September 9, 2025 12:18

jurgenbelien requested review from bazottie and decrek September 9, 2025 12:21

jurgenbelien force-pushed the feat/special-pages branch from 9d0ced6 to 6e3567c Compare September 9, 2025 13:40

bazottie reviewed Sep 15, 2025

View reviewed changes

Comment thread config/datocms/migrations/1752588127_featSpecialPages.ts Outdated

feat(datocms): migrate special page singletons to regular pages

a749579

jurgenbelien added 7 commits September 16, 2025 15:44

feat(scripts): download app settings in prep

bb56cb5

docs: explain how to add required Home Page and Not Found Page settings

5d55e22

feat: remove Home singleton, hardcode home page

764365f

test(content): add test for Pages collection

0078fe0

feat(pages): use SpecialPages collection to render 404

1594397

feat(content): use any page for homepage

437adfe

test(content): verify noIndex and purpose behavior

7c65408

jurgenbelien force-pushed the feat/special-pages branch from 6e3567c to 7c65408 Compare September 16, 2025 13:44

jurgenbelien marked this pull request as ready for review September 16, 2025 13:46

jbmoelker added the 🚏 Routing & Rendering label Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: special purpose pages content collection#294

feat: special purpose pages content collection#294
jurgenbelien wants to merge 13 commits intomainfrom
feat/special-pages

jurgenbelien commented Jul 20, 2025 •

edited

Loading

Uh oh!

jurgenbelien Jul 20, 2025

Uh oh!

jurgenbelien Jul 20, 2025 •

edited

Loading

Uh oh!

bazottie Sep 15, 2025

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 20, 2025 •

edited

Loading

Uh oh!

MarleenEliza left a comment

Uh oh!

jurgenbelien commented Jul 22, 2025 •

edited

Loading

Uh oh!

jurgenbelien Jul 22, 2025

Uh oh!

jurgenbelien Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jurgenbelien commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Associated issue

How to test

Checklist

Uh oh!

jurgenbelien Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

jurgenbelien Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bazottie Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying head-start with Cloudflare Pages

Uh oh!

MarleenEliza left a comment

Choose a reason for hiding this comment

Uh oh!

jurgenbelien commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jurgenbelien Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

jurgenbelien Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jurgenbelien commented Jul 20, 2025 •

edited

Loading

jurgenbelien Jul 20, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jul 20, 2025 •

edited

Loading

jurgenbelien commented Jul 22, 2025 •

edited

Loading