Conversation
- Add setup.py and setup.cfg for Python package management - Update package.xml and removed CMakeLists.txt - Update launch file executable reference - followed the structure in vortex_image_segmentation Resolves #55
…5-refactor-yolo_object_detection-to-use-ament_python
…lar format to yolo_object_detection node
- Remove buildtool_depend from package.xml (rosdep incompatible) - Standardize setup.cfg format (use underscores: script_dir, install_scripts) - Align setup.py to use consistent 'from glob import glob' import style - Fixes rosdep error: "Cannot locate rosdep definition for [ament_python]" Aligned packages: - vortex_yolo_classifiy - yolo_object_detection - yolo_obb_object_detection - vortex_image_segmentation
kluge7
requested changes
Apr 14, 2026
Contributor
kluge7
left a comment
kluge7
left a comment
There was a problem hiding this comment.
First round of review, good work so far, I havent tested it yet so will need to try that.
Contributor
There was a problem hiding this comment.
why do we just have an empty file here?
…std_msgs::msg::UInt8 out format
…CON had with venv files here
- Removed obsolete setup.cfg files from vortex_image_segmentation and vortex_yolo_classifiy. - Added .gitignore files to yolo_classify, yolo_obb_object_detection, yolo_object_detection, and yolo_segmentation to prevent model files from being pushed to git. - Created README.md and configuration files for yolo_classify, detailing usage and parameters. - Implemented classifier_node.launch.py for launching the YOLO classification node with device selection. - Established package.xml and setup.py for yolo_classify, defining dependencies and entry points. - Developed classifier_node.py for image classification using YOLO, including image subscription and result publishing. - Introduced yolo_segmentation package with similar structure, including parameters, launch files, and node implementation for segmentation. - Added yolo_seg.py for YOLO segmentation model handling and visualization. - Enhanced yolo_seg_node.py to manage image input, segmentation processing, and output publishing.
…_python - Updated configuration files for YOLO classification and object detection to use new parameter names and paths. - Created new launch files for YOLO classification and object detection, ensuring proper parameter handling and node initialization. - Refactored classifier_node and yolo_obb_object_detection_node to load parameters dynamically and improve model loading. - Introduced yolo_utils for shared functionality between classification and object detection. - Updated README and parameter files to reflect changes in topic names and configurations. - Enhanced error handling for model loading and parameter validation.
kluge7
deleted the
55-refactor-yolo_object_detection-to-use-ament_python
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #55