Open
Conversation
kent
force-pushed
the
kent/remove-abstain-quorum
branch
from
e9e453d to
0da2319
Compare
cairoeth
changed the title
cairoeth
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick implementation to remove abstain votes from the quorum calculation along with some tests.
This change was as a result of a deep dive form the OP Foundation, from Josiah from the Foundation:
"This change removes Abstain votes from our Quorum calculation in order to address an edge case where casting Abstain votes has the unintended aside-effect of reducing the number of votes needed to determine the outcome of a proposal in instances where quorum has not yet been met."