select first orc as default when default is delegated#7285
select first orc as default when default is delegated#7285CamronStaley merged 1 commit intodevelopfrom
Conversation
WalkthroughThe change modifies how default options are generated for orchestrator schedules in the prompt submission logic. Instead of iterating directly over Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/packages/operators/src/state.ts`:
- Around line 326-334: The loop is iterating over
execDetails.executionOptions.availableOrchestrators instead of the
already-defined availableOrchestrators variable; update the for...of loop to
iterate over availableOrchestrators (preserving the destructuring of [index,
orc]) so the block that pushes into options still uses the same single source of
truth (keep the defaultToSchedule && index === 0 logic and references to orc.id
and orc.instanceID intact); this makes the code consistent with
hasAvailableOrchestrators and the earlier variable declaration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 522410e1-7aca-482d-92c0-8fce11a03017
📒 Files selected for processing (1)
app/packages/operators/src/state.ts
🔗 Related Issues
📋 What changes are proposed in this pull request?
If we have multiple orcs, immediate execution, and default to delegated we don't currently select an orc as the default instead it goes to "execute". This fixes that by defaulting to the first orc listed
🧪 How is this patch tested? If it is not, please explain why.
deployed in teams here: https://camron.ephem.fiftyone.ai/datasets/quickstart/samples
📝 Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
If your operator defines "default_choice_to_delegated" as true and allows immediate execution now the UI will automatically select an orc to schedule on instead of "execute immediately".
What areas of FiftyOne does this PR affect?
fiftyonePython library changesSummary by CodeRabbit