Improve Handling of sensitive Data#791
Open
cocker-cc wants to merge 2 commits intovoxpupuli:masterfrom
Open
Conversation
kenyon
reviewed
Mar 2, 2026
Member
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
Thanks! We should link to the regsubst PR, otherwise looks good.
cocker-cc
force-pushed
the
Improve_Handling_of_sensitive_Data
branch
from
079f347 to
cf5e8cd
Compare
Breaking Change: Let Function mongodb_password() dynamically react on sensitive Input, while removing optional Parameter "sensitive".
kenyon
approved these changes
Mar 2, 2026
kenyon
added
the
backwards-incompatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Remove unneeded
unwrapAs soon as Openvox-regsubst flawlessly accepts Sensitive, like Puppet-regsubst does. (PR pending) the original Line in
templates/mongoshrc.js.eppcan be restored: