json: Make fromjson less confusing when used with a decode_value#1269
Merged
json: Make fromjson less confusing when used with a decode_value#1269
Conversation
Decoders, like fromjson (uses decode("json")), in fq tries to get a binary from
its input which in the case of a decode_value is by default its back binary. So
when doing '.. | fromjson | fromjson' the second fromjson will get the same input
as the first one. Fix this by doing "tovalue" before decoding as json.
Note that this change only affects fromjson/0 and not the fq specific json/* and
from_json/* which will still behave the same as other decoders. So this is more of
jq compatilbility fix.
Fixes #1268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoders, like fromjson (uses decode("json")), in fq tries to get a binary from its input which in the case of a decode_value is by default its back binary. So when doing '.. | fromjson | fromjson' the second fromjson will get the same input as the first one. Fix this by doing "tovalue" before decoding as json.
Note that this change only affects fromjson/0 and not the fq specific json/* and from_json/* which will still behave the same as other decoders. So this is more of jq compatilbility fix.
Fixes #1268