This repository was archived by the owner on May 8, 2019. It is now read-only.
Refactored and fixed the add_slashes function#62
Open
mekhami wants to merge 2 commits into
Open
Conversation
Author
|
In general it's probably just pointless to even have the add_slashes function when you could just use re.escape. But that's not something I'm gonna decide for you :) |
Contributor
|
Thanks! Yep, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things I found wrong with this function. One, there's no reason to define it within the top level function. Something like this is both reusable, doesn't play with weird namespaces, so it should be made available at the top level.
Second, it didn't actually do anything. Period. Strings are immutable, so it does all the replaces you want but doesn't actually "save" the results.