Copy of #112 to troubleshoot sqlite CI failures - #113
Closed
gasman wants to merge 3 commits into
Closed
Conversation
gasman
force-pushed
the
treebeard-sync-2
branch
from
September 2, 2026 12:51
0976919 to
dcc2d01
Compare
Various tests were redundantly calling self.backend.add on model instances created during tests. This is unnecessary because the post_save signal handler is in force (AUTO_UPDATE is True on the backend), and the task runner is set to ImmediateBackend (and since django-tasks 0.10 this no longer waits until the end of the transaction). However, calling refresh() on the index is still necessary to flush all pending operations at the Elasticsearch/Opensearch end. test_add_bulk has the opposite problem - we don't want the signal to be triggered, so that we can verify that add_bulk is doing its job. So, create the records with bulk_create to bypass the signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.