Fix pagination page links on index page - #15
Merged
Conversation
Numbered page links were derived by regex-replacing trailing digits from page.url.current, which is '/' on the index page — so pages 2+ linked back to '/'. Derive the /page/N pattern from page.url.last instead, which is populated on every paginated route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page 2 / page 3 circles on the index page linked back to
/instead of/page/2and/page/3.Pagination.astroderives numbered page links by regex-replacing trailing digits frompage.url.current(current.replace(/\/\d+$/,/${n})). The paginated routes passcurrent: '/page/2', which works — butsrc/pages/index.astropassescurrent: withBase('/'), which has no trailing digits, so the replace was a no-op and every numbered link resolved to/.Fix
Derive the
/page/NURL pattern frompage.url.lastinstead (always/page/<lastPage>on every paginated route), with page 1 usingpage.url.first ?? page.url.current.Verification
Rebuilt the site and extracted every pagination link from the built HTML:
/→ 2 →/page/2, 3 →/page/3(the reported bug)/page/2,/page/3,/page/4→ all neighbour links correct/developers/,/developers/page/2→ unaffected, still correctRebased on latest
main(includes #5).